Skip to content

Add Claude review workflow#5258

Merged
leighmcculloch merged 1 commit into
masterfrom
add-claude-review-workflow
May 11, 2026
Merged

Add Claude review workflow#5258
leighmcculloch merged 1 commit into
masterfrom
add-claude-review-workflow

Conversation

@leighmcculloch
Copy link
Copy Markdown
Member

Description

Add Claude review workflow.

To get a larger variety of review perspectives on changes.

The prompt in the workflow is super basic as a starting point. I'm curious to see how it fares initially without too much specialisation. I expect with the skills in this repo a better prompt is possible, but I'd start with this, and potentially run a separate prompt to compare before eagerly specialising.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copilot AI review requested due to automatic review settings May 7, 2026 22:58
@leighmcculloch
Copy link
Copy Markdown
Member Author

Closing because this workflow won't work for this repo because all contributions are from forks, and some thoughtful approach to only running on forks from members will be needed.

@leighmcculloch leighmcculloch reopened this May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow to automatically run an Anthropic Claude-based PR review on key pull request events, aiming to provide additional review perspectives alongside existing CI.

Changes:

  • Introduces .github/workflows/claude-review.yml triggered on PR open/sync/reopen/ready-for-review events.
  • Configures per-PR concurrency cancellation to avoid overlapping runs.
  • Runs anthropics/claude-code-action with a basic review prompt and inline-comment tooling.

Comment thread .github/workflows/claude-review.yml Outdated
Comment thread .github/workflows/claude-review.yml
Comment thread .github/workflows/claude-review.yml
anupsdf
anupsdf previously approved these changes May 7, 2026
@anupsdf anupsdf requested a review from graydon May 8, 2026 00:54
Comment thread .github/workflows/claude-review.yml Outdated
Comment thread .github/workflows/claude-review.yml
Comment thread .github/workflows/claude-review.yml
@leighmcculloch
Copy link
Copy Markdown
Member Author

@kanwalpreetd Thanks for the solid review. I've addressed your feedback.

@leighmcculloch leighmcculloch force-pushed the add-claude-review-workflow branch from cd33d72 to 36a4291 Compare May 8, 2026 12:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/claude-review.yml
@leighmcculloch leighmcculloch added this pull request to the merge queue May 11, 2026
Merged via the queue into master with commit 1b0eccd May 11, 2026
58 checks passed
@leighmcculloch leighmcculloch deleted the add-claude-review-workflow branch May 11, 2026 15:20
marwen-abid pushed a commit to stellar/stellar-disbursement-platform-backend that referenced this pull request May 27, 2026
### What

Apply a best practice to the `automated_release_process` workflow:

- Move the broad `contents: write`/`pull-requests: write`/`issues:
write`/`id-token: write` scope from workflow level to the single job
that needs it; set top-level `permissions: {}` so any future job added
to this file inherits nothing by default.

### Why

This is pretty minor, but brings this workflow in line with the
Claude-action security standards being applied across the stellar org
(see `stellar/stellar-core` [PR
#5258](stellar/stellar-core#5258) and the
[claude-code-action security
guide](https://github.com/anthropics/claude-code-action/blob/main/docs/security.md)).
Without `permissions: {}` at the workflow root, any future job added to
this file would silently inherit the broad write scopes. Moving them to
the job level limits the blast radius if this workflow expands in the
future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants