Use shared claude-review reusable workflow#5270
Conversation
There was a problem hiding this comment.
Pull request overview
Replaces the inlined claude-review.yml workflow with a call to the shared reusable workflow at stellar/actions/.github/workflows/claude-review.yml@main, centralizing the Claude PR review configuration across stellar repos while preserving the pull_request_target flow and author-association gating in the reusable workflow.
Changes:
- Removes ~120 lines of inlined workflow logic, security comments, and Claude action configuration.
- Delegates to the shared reusable workflow, passing
ANTHROPIC_API_KEYas a secret. - Narrows trigger types to
[ready_for_review, synchronize](dropsopenedandreopened).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a83e2cab9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # if a future job is added without its own `permissions:` block it inherits | ||
| # nothing, rather than whatever the repo or org default happens to be. | ||
| permissions: {} | ||
| types: [ready_for_review, synchronize] |
There was a problem hiding this comment.
Include opened/reopened pull_request_target triggers
Limiting pull_request_target to ready_for_review and synchronize stops Claude from running on the first review cycle for PRs that are opened as non-draft (and on PRs that are reopened without new commits). ready_for_review only fires when converting a draft PR, so many normal PR openings will get no review until another push happens.
Useful? React with 👍 / 👎.
Description
Replace the inlined
claude-review.ymlworkflow with a call to the shared reusable workflow atstellar/actions/.github/workflows/claude-review.yml@main. The new reusable workflow preserves the samepull_request_targetflow, author-association gate,pr-head/isolated checkout, andpermissions:posture that this repo already used. This repo stays onpull_request_target(rather than the saferpull_requestdefault that the other stellar callers use) because contributions arrive via forks from org members and Claude needs to be able to review them. The trigger types are narrowed to[ready_for_review, synchronize]so Claude only reviews PRs that are marked ready and re-reviews on new commits.The same claude-review workflow is now centralized in
stellar/actionsso all stellar repos using it share one hardened implementation. The previous version here was the source-of-truth for the security model; that model now lives in the reusable workflow's inline security note. The caller workflow shrinks to ~15 lines:The default prompt in the reusable workflow keeps the
pr-head/note this repo's prompt had and adds the GitHub CLI usage guidance from the other repos.Requires the corresponding PR in
stellar/actionsto be merged first so thatstellar/actions/.github/workflows/claude-review.yml@mainresolves:Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)