Simulate sleep in apply before posting back to main#5297
Merged
Conversation
SirTyson
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts where test-only ledger-apply sleep simulation occurs so that the simulated delay happens before applyLedger publishes results back to the main thread (or advances state directly when already on main). This better aligns the “simulated apply time” with the point at which the main thread observes ledger-apply completion.
Changes:
- Move
maybeSimulateSleep(...)(BUILD_TESTS-only) to run beforeadvanceLedgerStateAndPublish/postOnMainThread. - Preserve the existing sleep-duration calculation logic (based on op count and elapsed apply time so far).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.