Add use 'upload' instead of 'install' in routes#1972
Add use 'upload' instead of 'install' in routes#1972ElliotFriend merged 3 commits intostellar:mainfrom
Conversation
|
Preview is available here: |
|
@ElliotFriend @fnando I've opened this PR too, to make the updates to the "install" cookbook pages related to stellar/stellar-cli#2277. I'm not sure if I've done this with the correct process to make sure that the docs & routes match up between repos. Could I get some help with that? |
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Yeah, timing things with the CLI docs is a little wonky atm. docs are having other build problems anyway, so i think we're fine to merge. this one looks good to me!
do me a favor, and add some redirects, and it'll be even readier to merge! If you can add these two lines:
rewrite ^/docs/tools/cli/cookbook/install-(deploy|wasm)(.*)$ "/docs/tools/cli/cookbook/upload-$1$2" permanent;
rewrite ^/docs/build/guides/cli/install-(deploy|wasm)(.*)$ "/docs/tools/cli/cookbook/upload-$1$2" permanent;
right above the line that goes like rewrite ^/docs/build/guides/cli(.*)$ "/docs/tools/cli/cookbook$1" permanent;, should be all set!
I tried to do it myself, but my local branch couldn't push to the pull request for whatever reason 🤷🏻♂️
|
@ElliotFriend just pushed those redirects! Thanks for taking a look! I wonder if you're not able to push to my branch because iI had to open this PR from a fork, because I don't think I have direct push access to this repo |
|
that could be it. sometimes forked repos act a little funky (like with the routes-removal action that's failing, which i'll happily ignore in this situation lol) do you have the "allow commits from maintainers" (or whatever the wording) setting turned on for this pr? |
|
Preview is available here: |
I'm not seeing that setting available for some reason. 🤔 |
|
Preview is available here: |
|
@elizabethengelman weird that the option doesn't who up.. 🤷🏻♂️ in any case, it looks good to me! i'll merge this, and then you should be all good to merge the cli pr whenever you're ready |
|
thank you! |
3 participants
Related CLI PR: stellar/stellar-cli#2277