Review PR #2313: Fee stats analytics docs refresh#2315
Draft
Conversation
Copilot
AI
changed the title
[WIP] Review pull request for completeness
Review PR #2313: Fee stats analytics docs refresh
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2313 refreshes the Hubble fee stats documentation to reflect the deprecation of
fee_stats_aggin favor of two new granular models.What was reviewed
queries-for-horizon-like-data.mdx): Deprecation note added; old single query replaced with two new sections —Retrieve Daily Fee StatsandRetrieve Ledger-Level Fee Stats— each targeting the new BigQuery tablesgold/ledger-fee-stats-agg.mdx(sidebar_position: 81) — per-ledger grain, includes Classic/Soroban breakdowns, inclusion fee metrics, surge pricing flagsgold/daily-fee-stats-agg.mdx(sidebar_position: 82) — daily rollup with surge percentages and ledger-count summariesroutes.txt: Two new routes registered for the new dictionary pagesIssues resolved
A prior automated review flagged that the
Documentationrows in both new.mdxfiles were malformed — prefixed with an MDX comment instead of being valid table rows. This was fixed in the "Remove TODOs, docs are verified" commit:Both files now follow the same structure as existing gold-layer data dictionary pages (
fee-stats-agg.mdx,asset-balances-daily-agg.mdx, etc.), with consistent dbt docs URL format and<div className="scoped-data-dictionary-table">wrapper.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.