🐛 Patch Zustand persist storage fallback#2415
Open
JFWooten4 wants to merge 1 commit intostellar:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s patch-package override for zustand@3.7.2 to prevent failures when a custom Zustand persist storage adapter does not implement removeItem, by installing a no-op fallback.
Changes:
- Replace the persist middleware warning for missing
removeItemwith a no-opremoveItemassignment. - Apply the same fallback across the CJS, ESM (
.jsand.mjs), SystemJS, and UMD builds shipped in thezustandpackage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This showed up across different platforms when running
yarn build(at the end, after everything else succeeds).Build error remedied:
Changes
This patch adds a no-op
removeItemfallback when the configured Zustand persist storage adapter does not provide one.Previously, Zustand only logged a warning when
removeItemwas missing. With this patch, the middleware assigns an empty fallback function instead, preventing downstream calls such asclearStorage()from failing when a custom storage implementation does not support removal.This is applied across the CommonJS, ESM, SystemJS, and UMD middleware builds included in the package patch. It lays the framework for a more comprehensive solution if we want to tackle the Actions cleanup drops.