Update Workflows for RPC Only Release#6
Merged
stellarsaur merged 8 commits intomainfrom Feb 1, 2024
Merged
Conversation
13 tasks
Contributor
|
Nice docs!!! |
2opremio
approved these changes
Jan 31, 2024
sreuland
reviewed
Feb 1, 2024
tamirms
pushed a commit
that referenced
this pull request
Mar 13, 2026
karthikiyer56
added a commit
that referenced
this pull request
Apr 27, 2026
Closes the only remaining filesystem-scan in the design. Phase 3 (reconcile)
now iterates meta-store keys instead of scanning {ACTIVE_STORAGE.PATH}/.
- New keys: hot:chunk:{C:08d}:lfs, hot:chunk:{C:08d}:events,
hot:index:{N:08d}:txhash. Binary "1"/absent. Set BEFORE mkdir (inside
open_active_*_store), cleared AFTER delete_dir (inside the freeze tasks).
- Phase 3 reconcile: replaces 3 filesystem-scanning helpers with one
scan_prefix("hot:") loop dispatching by store_kind +
chunk_or_tx_index_id. Clean if/elif/else chain with 4 scenarios
(resume target / flag-is-truth cleanup / interrupted freeze /
future-orphan defensive). delete_dir_if_exists everywhere; log.warn
on the future-orphan branch.
- Phase 2 hydration: open_active_txhash_store now takes meta_store and
encapsulates the hot-key write. No new code lines in phase2 body.
- Naming unification: open_or_create_*_store -> open_active_*_store
across all callsites. finish_interrupted_*_freeze drops the redundant
store_dir parameter (derivable from chunk_id under hot-key tracking).
- Flag Semantics: third rule (flag-driven recovery) now applies
universally; no implicit "data artifacts only" scope.
- Resilience invariants: new invariant #6 (hot-key tracking).
- Compound Recovery Scenarios: refreshed Phase 3 entries; new entries
for crash-mid-hot-store-creation and crash-between-dir-delete-and-
hot-key-clear.
Source-of-truth + handoff updated in lockstep (untracked, in .claude/
and ~/.claude/projects/.../streaming-artifacts/).
Anchors revalidated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Related to the RPC/CLI repo split.
This PR prepares GitHub workflows to release Soroban RPC from the
soroban-rpcrepo, rather than packaged with the CLI in thesoroban-toolsrepo.Why
See this issue for motivation behind splitting up the repos and release processes.