Fix failure to check error result from BuildEventsJSONFromTransaction()#616
Merged
Fix failure to check error result from BuildEventsJSONFromTransaction()#616
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect error handling in the getTransactions endpoint by checking the actual error returned from BuildEventsJSONFromTransaction().
Changes:
- Replace a stale
errcheck withconvErrafter callingBuildEventsJSONFromTransaction(tx).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Shaptic
approved these changes
Feb 27, 2026
Contributor
|
Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a
nil == nilerror checking bug.Why
An error value is assigned to
convErr, but the stale/confirmed-nil variableerris checked instead. This leads to never checking the return status ofBuildEventsJSONFromTransaction()in thegetTransactionsendpoint, which can plausibly return an error.Known limitations
N/A