Preserve version string in Cargo.toml on automatic dependency bump#672
Merged
Preserve version string in Cargo.toml on automatic dependency bump#672
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the scripts/update-soroban-env.sh automation so that when bumping soroban-env dependencies to a git rev, the corresponding version = "...“ constraint in Cargo.toml is preserved/updated (rather than being removed), matching the workflow described in #671.
Changes:
- After
cargo update, re-reads the resolvedsoroban-env-hostandsoroban-simulationversions fromCargo.lock. - Writes those resolved versions back into
Cargo.tomlas pinned=...version strings for the*-currworkspace dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
urvisavla
approved these changes
Apr 7, 2026
karthikiyer56
added a commit
that referenced
this pull request
Apr 9, 2026
* Bump soroban-env to next protocol version (#595) * Bump soroban-env to next protocol version * Add required config key to mocked ledger entries * Integrate unstable-next-api into curr (dropped arg) * Bump soroban-env SHA to latest (#611) * Update XDR and Core runs to test P26 integration (#629) * Split the single core_version input into core_deb_version and core_docker_img to accommodate differences. * Bump Core versions for P25 and add P26 run * Bump Golang to 1.25 and linter to be compatible * Bumped soroban-env-host curr to latest commit SHA in repo * Bumped Go SDK to latest @protocol-next * Added P26 limits from quickstart and removed P24 limits * Bump crate dependencies to latest Protocol 26 versions (#640) * Remove unimplemented GitHub Action (#643) Snuck in with a `git add -A` on accident * Bump Core to Protocol 26 release candidate (#642) * Bump Core to p26 release candidate * Bump Go SDK version to latest * Bump to official patched env * Ensure we strip NUL bytes before `CString::new` (#632) * Fix deluge of linter complaints on branch merge (#646) * Release v26.0.0 (#647) * Tag off changelog for major release * Bump Go SDK to official P26 version * Bump CI to latest stable core for a final run * Add GHA to automatically update soroban-env on protocol-next (#645) * Preserve version string in Cargo.toml on automatic dependency bump (#672) * Preserve version= in Cargo.toml on bump * Simplify code: use a function, better names * Bump to soroban-env to latest version (#673) --------- Co-authored-by: George <Shaptic@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddharth@stellar.org> Co-authored-by: George <george@stellar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #671. Instead of
we will now have