Make return value optional in Soroban meta v2#264
Merged
dmkozh merged 1 commit intostellar:currfrom Apr 10, 2025
Merged
Conversation
Making it non-optional was an oversight; extend TTL and restore ops shouldn't have a return value (currently we end up using the default SCVal, which is `false`).
sisuresh
approved these changes
Apr 10, 2025
dmkozh
added a commit
to dmkozh/stellar-xdr-next
that referenced
this pull request
Apr 10, 2025
Making it non-optional was an oversight; extend TTL and restore ops shouldn't have a return value (currently we end up using the default SCVal, which is `false`).
dmkozh
added a commit
that referenced
this pull request
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it non-optional was an oversight; extend TTL and restore ops shouldn't have a return value (currently we end up using the default SCVal, which is
false).