Hotfix: Use hook prefix with event action#83
Merged
Conversation
Contributor
ChrisMKindred
left a comment
ChrisMKindred
left a comment
There was a problem hiding this comment.
It looks like this will take care of the action triggering by slug, were you going to address the shutdown send for events as well or is that going to be in a different pr?
Member
Author
|
@ChrisMKindred - I'll update this to include that functionality so we can push out a single patch. |
Member
Author
|
@ChrisMKindred after thinking about it, I decided to make it a separate PR anyway (#84) |
Contributor
|
let's bring the two hotfixes together in a single branch to merge into main in that case. |
Member
Author
|
@ChrisMKindred since we're so close to the next release (week of 10/2), It makes sense to merge this into develop and push it out with the next minor release version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://moderntribe.atlassian.net/browse/FRAME-175
This fixes an issue where events fired with the existing action would be fired for each individual instance of the library running on a site. Adding a hook prefix prevents this and only fires the action with the library of the associated prefix.