[FRAME-176]: Delay Events Until Shutdown#84
Merged
Conversation
Use the same process for hooking into the "shutdown" action and spin off async requests for sending each cached event to the telemetry server.
Contributor
ChrisMKindred
left a comment
There was a problem hiding this comment.
This is a great first step to the fix. The lift would be very low to add an events endpoint to the server and send all the events in one request. As rare as it might be, the event cache could be large, and calling an admin-ajax request for each is inefficient.
ChrisMKindred
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functionality to cache all events for the request until the
shutdownaction. Then duringshutdowneach event request is sent in a similar fashion to how we send the telemetry data.This should keep the user from needing to wait for the requests to send, but it does not prevent the server from being overloaded if a plugin sends a large number of requests on each page load.