Skip to content

(Closes #3334) Make module-inlining mandatory for Kernel transformations#3388

Merged
sergisiso merged 28 commits intomasterfrom
3334_take_two
Apr 20, 2026
Merged

(Closes #3334) Make module-inlining mandatory for Kernel transformations#3388
sergisiso merged 28 commits intomasterfrom
3334_take_two

Conversation

@arporter
Copy link
Copy Markdown
Member

A second attempt at this after my git fu let me down badly.
Original changes are here: https://github.com/stfc/PSyclone/pull/3294/changes#diff-436bf7f3b5f30b4c1d6ff1f9a0a8e144f924bae78cbcc9595b30fc5954e715e0

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (3477550) to head (9f8bd35).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         388      389       +1     
  Lines       54507    54377     -130     
==========================================
- Hits        54485    54355     -130     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Copy Markdown
Member Author

ITs were all green and coverage is now OK. Ready for a first review from @hiker, @LonelyCat124 or @sergisiso.

@sergisiso
Copy link
Copy Markdown
Collaborator

I got worried that the previous PR which still had several open comments ended saying it was merged:
image

But what happened is that those commits were part of the 1734_stricter_symbols branch, with follow up commits reverting the changes, and github spoted that those were merged. @arporter This is probably why you coudn't see the changes after brining the branch it to master, the master history already had those commits plus commits reverting them.

Anyway I've checked that the comments I made in the previous PR are now addressed or ported to the new review.

Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter Most comments raised in the other PR are now resolved. There is just some minor clean up/clarfications to do.

Comment thread doc/user_guide/psyclone_command.rst
Comment thread src/psyclone/transformations.py
@arporter
Copy link
Copy Markdown
Member Author

Ready for another look now, I've just fired-off the ITs again.

Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter All comments have been addressed and the integration test pass. I could not find more mentions of the old functionallity. Thanks for the multiple takes on this, it's a good simplification of the codebase and the documentation.

@sergisiso sergisiso merged commit 4a0546a into master Apr 20, 2026
16 of 18 checks passed
@sergisiso sergisiso deleted the 3334_take_two branch April 20, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants