optBoolean isn't optional

[quidryan]

JSONObject::optBoolean no longer catches the exception thrown by JSONObject::get. This means that while it's called "opt" (optional), it throws an exception if not found. It's broken in a few recent versions of org.json.

[stleary]

Thanks for catching this! Will fix it soonest. Looks like #249 and #253 will need to be reverted. @johnjaylward if you can come up with a way to retain #253 while #249 is reverted, please let me know.

[johnjaylward]

@stleary it looks like all the opt functions have this issue, or at least most. They should be changed from

Object object = this.get(key); 

to

Object object = this.opt(key);

to prevent the missing key exception.

[stleary]

Agreed, another code change may fix it. But the unit tests did not catch it, so they will need to be tightened up too. If this simple bug is in the commit, others may have been included as well. There was no strong case for this pull request, it was supposed to be minor refactoring. On the plus side, it looks like it can be reverted without affecting your latest commit.

[quidryan]

With the better tests proving that this is fixed, we can maybe fix forward.

[stleary]

Addressing this in #261, please post comments there going forward.

[johnjaylward]

I'm updating the test cases now to take this into account