allow buffer length of zero for Adswrite / adsSyncWriteReqEx#515
Open
CagtayFabry wants to merge 3 commits intostlehmann:masterfrom
Open
allow buffer length of zero for Adswrite / adsSyncWriteReqEx#515CagtayFabry wants to merge 3 commits intostlehmann:masterfrom
CagtayFabry wants to merge 3 commits intostlehmann:masterfrom
Conversation
CagtayFabry
changed the title
Coverage Report for CI Build 25163043597Coverage at 93.267% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change allows
adsSyncWriteReqExto handle write requests with a buffer length of zero (no data)This edge case is necessary to support ADS timestamp correction based on time providers configured in TwinCAT 3.
This feature requires a recent version of
adslibto be installed (implemented upstream since commit standalone/AdsLib: allow AdsWrite for zero length buffer )closes #335
ref: Beckhoff/ADS#264