Fix: map ADST_INT8 to PLCTYPE_SINT instead of PLCTYPE_BYTE#519
Merged
stlehmann merged 1 commit intoMay 19, 2026
Merged
Conversation
Coverage Report for CI Build 25850838429Coverage remained the same at 93.407%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Owner
|
@AskicV thanks for this....merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ADST_INT8 represents TwinCAT SINT, a signed 8-bit integer (-128 to 127).
It was incorrectly mapped to PLCTYPE_BYTE (c_ubyte, unsigned 0-255),
causing an exception when writing values to variables of this data type.
Root cause
In src/pyads/constants.py:
ADST_INT8: PLCTYPE_BYTE ← c_ubyte is unsigned (0-255)
Fix
ADST_INT8: PLCTYPE_SINT ← c_int8 is signed (-128 to 127)