feat: Screen share settings UI modal#1111
Open
Dadadah wants to merge 11 commits intostoatchat:mainfrom
Open
Conversation
587e295 to
5a2b4b6
Compare
Dadadah
commented
Apr 12, 2026
| @@ -72,87 +77,89 @@ export function ParticipantTile(props: TileProps) { | |||
| }; | |||
|
|
|||
| return ( | |||
Member
Author
There was a problem hiding this comment.
I know the diff looks big here, but I actually just wrapped this in a big show block to disable showing screen shares if they're muted (as is the case when a screen share is getting configured)
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
3919785 to
8b6113d
Compare
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a screen share settings UI modal that pops up after choosing what window/screen to stream. It allows you to choose a screen share quality. Right now it only supports 720p@30fps, 1080p@30fps and Source@5fps. These values will only show up if the server is configured to allow streams of that size. The
Source@5fpsquality setting will cap the width and height to the configured limit, unless the limit is 0. The modal has a checkbox to not show the modal again. If you check this box, it will save your choice and disable the modal. You can enable it in the settings. You can also change the default screen share resolution chosen in the settings. TheVoicesettings section has been renamed toVoice & Video.Requires stoatchat/javascript-client-sdk#149Requires #1112This PR is blocking #1070 and #1068
Closes #1069
How was this PR tested?
Shared screen from one client to another. Shared multiple screen resolutions and both landscape and portrait screens.
Simulated low resolution cap to ensure only low quality streaming was allowed (720p).
Screenshots & Screencasts (if appropriate)
In action:
Screencast.from.2026-04-11.17-18-42.webm
Settings UI:

Available resolutions:

Known Issues
Checklist:
Please declare, if any, LLM usage involved in creating this PR
Generative AI was not used in the creation of this PR.