Add Client.run#16
Closed
Dark42ed wants to merge 2 commits into
Closed
Conversation
Author
|
This will simply the example code to this: import revolt
class Client(revolt.Client):
async def on_message(self, message: revolt.Message):
if message.content == "hello":
await message.channel.send("hi how are you")
client = Client()
client.run("BOT TOKEN HERE") |
Member
|
Thanks, but no thanks, but i dont want to hide away the handling of the event loop from the user using this library, and i dont want to dynamically set the session on the client like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord.py has a run method for ease of access that automatically creates the asyncio loop and starts the client. I was thinking about adding that to here because it would help simplify the process of creating and running a bot.
Note: We could put the
runner()method into the class such as_run_asyncinstead of having it inside the run method.