feat: tweak DelegationsStorage#putMany to make cause optional - #804
Merged
travis merged 2 commits intoJun 6, 2023
Merged
Conversation
Move the `cause` parameter of `putMany` into an options hash and make clear that it is an optional parameter intended to allow some storage implementations to not store delegations themselves but instead rely on CID-identified UCAN invocations that they already have access to.
travis
marked this pull request as ready for review
June 6, 2023 20:40
Gozala
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
causeparameter ofputManyinto an options hash and make clear that it is an optional parameter intended to allow some storage implementations to not store delegations themselves but instead rely on CID-identified UCAN invocations that they already have access to.