Update pitney-bowes to v1.0.0 (async/await)#155
Merged
freshlogic merged 8 commits intomainfrom Apr 7, 2026
Merged
Conversation
- Replace callback-based pitneyBowesClient.tracking() with async/await - Remove async.retry wrapper (pitney-bowes no longer needs it) - Update error check from 'Not Found' to '404 Not Found' (HttpError format) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage Report for CI Build 24110222990Coverage increased (+4.5%) to 80.861%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Test tracking events, delivered/shipped detection, city blacklist filtering, Newgistics carrier name, 404 handling, minDate filtering, and IMB 31-digit tracking numbers. Uses native fetch mock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…At fallback Increases pitneyBowes.js coverage from 85.89% to 88.34% lines, 73.81% to 80.95% branches. Remaining uncovered lines are geocoder paths that require GOOGLE_API_KEY. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use eventTimeOffset from the PB API directly instead of geocoding event locations to determine timezones. Removes async and geography dependencies from this carrier. Coverage: 85.89% → 96.72% lines, 73.81% → 90% branches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
USPS API sometimes returns 503 Service Unavailable for malformed tracking numbers. Treat it the same as 404 (empty results). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage: 96.72% → 99.18% lines, 90% → 96.77% branches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pitney-bowesdependency from~0.3.1to~1.0.0pitneyBowesClient.tracking()with Promise-based call (v1.0.0 is pure async/await)async.retrywrapper — no longer needed'Not Found'to'404 Not Found'(newHttpErrorformat)Test plan
🤖 Generated with Claude Code