-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Web-components: Export html helper for custom render functions #30982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 9e878da
☁️ Nx Cloud last updated this comment at |
|
The sample components still use This is "user" code instead of story code, so I didn't update it to use Storybook's |
6894cc0 to
9e878da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
34 files reviewed, no comments
Closes #30979
What I did
htmlChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Create a WC sandbox and run it. Add a story with a custom render function.
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This review covers only the changes made since the last review (commit ba1b8f5), not the entire PR.
The recent changes address the previous typo feedback and include several additional documentation updates across web-components examples. The main changes include:
index.tshas been corrected to "stories that compose multiple web components"import { html } from '@storybook/web-components'instead ofimport { html } from 'lit'MIGRATION.mddocumenting the breaking change for Storybook 9.0litdependency fromweb-components-webpack5package to avoid conflictslit-htmlconsistentlyThese changes complete the standardization effort by ensuring all documentation examples demonstrate the new import pattern where users import the
htmlhelper from@storybook/web-componentsrather than directly fromlit. This provides a more consistent API surface and better encapsulation for the web-components renderer.Confidence score: 4/5
docs/_snippets/list-story-starter.mdwhich has a TypeScript example usinghtmlwithout importing it