This repository was archived by the owner on Apr 30, 2024. It is now read-only.
Simplify registration proccess #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
jdubpark,
kingster-will and
leeren
and removed request for
jdubpark and
kingster-will
leeren
reviewed
Jan 31, 2024
Ramarti
force-pushed
the
simplify_registration_proccess
branch
from
cff69a1 to
9dede5c
Compare
leeren
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolicyFrameworkas a data struct in LicenseRegistry, so we just use the framework address for ID and we move the related data to thePolicyFrameworkManagercontract--
addPolicy()is renamedregisterPolicy()since it's the one well, registering data into LicenseRegistry-- Since we have
PolicyFrameworkManagernow, there is no need to passPolicystruct, justbytes dataand LicenseRegistry will create the Policy object with the sender (the manager).