This repository was archived by the owner on Apr 30, 2024. It is now read-only.
Cleanup and Minimize Base Module Attributes #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just realized that we could even go further and merge BaseModule and AccessControlled - given that AccessControlled does not need to be called on its own independently from BaseModule. Can be a future improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, it focus on refining the base module by cleaning up and minimizing its attributes.
BaseModule supposed to be inherited by all modules, It will force all modules has some common attributes or functions. we need to decide which attributes/functions require all modules to have, more smaller scope more better. for example, not all modules need access to LicenseModule or LicenseRegistry.
Not interface change introduced in this PR.