This repository was archived by the owner on Apr 30, 2024. It is now read-only.
Registration Module backward compatibility #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
force-pushed
the
registration-module-backward-compatibility
branch
from
0ef1985 to
c7f1d96
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #74 added an extra path to register IPAssets. It checks for token ownership for the caller in an internal function called by both the registration module and IPAssetRegistry. If a user calls through the registration module to register an IPAsset, the registration module becomes the msg.sender when checked in the internal function in IPAssetRegistry.
Hence, we remove the check in the internal function and pull it out to each register function in IPAssetRegistry as a temporary solution to make the new changes in IPAssetRegistry backward compatible.