ci: update ruff requirement from <0.14.0,>=0.13.0 to >=0.13.0,<0.15.0 #1004
Conversation
dependabot
bot
added
dependencies
mkmeral
left a comment
mkmeral
left a comment
There was a problem hiding this comment.
Agentic review on version changes:
Summary
I've completed the review of PR #1004. Here are my findings:
✅ SAFE TO MERGE
This is a straightforward Dependabot PR that updates the ruff version constraint from >=0.13.0,<0.14.0 to >=0.13.0,<0.15.0, allowing ruff 0.14.x.
Key Findings:
-
Single File Changed: Only
pyproject.tomlmodified (2 locations updated) -
Ruff 0.14.0 Breaking Changes: The only breaking change is Python 3.14 version defaults, which doesn't affect this project (targets Python 3.10-3.13)
-
Quality Checks:
- ✅ Ruff formatter: Passed (196 files formatted)
- ✅ Ruff linter: Passed (all checks passed)
⚠️ Mypy: 3 errors (but these are PRE-EXISTING, not caused by this PR)
-
Pre-existing Issues Found: There are 3 redundant cast warnings in
src/strands/types/_events.py(lines 270, 298, 316). I verified these exist in the main branch too, so they're not introduced by this PR. -
Bug Fixes in Ruff 0.14.0: Multiple improvements to annotation handling, f-string quoting, import ordering, and comment handling - all beneficial with no negative impact.
Recommendation:
Merge this PR immediately. The mypy errors should be fixed in a separate follow-up PR (they're minor code quality issues - redundant type casts that can be removed).
|
@dependabot rebase |
Updates the requirements on [ruff](https://github.com/astral-sh/ruff) to permit the latest version. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.13.0...0.14.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.14.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/pip/ruff-gte-0.13.0-and-lt-0.15.0
branch
from
53f1976 to
5e08ae7
Compare
dependabot
bot
deleted the
dependabot/pip/ruff-gte-0.13.0-and-lt-0.15.0
branch
| "pytest-asyncio>=1.0.0,<1.4.0", | ||
| "pytest-xdist>=3.0.0,<4.0.0", | ||
| "ruff>=0.13.0,<0.14.0", | ||
| "ruff>=0.13.0,<0.15.0", |
There was a problem hiding this comment.
Do we want to update the minimum to 0.14.0? I fear that we'll have some folks on 0.13 and some on 0.14
3 participants
Updates the requirements on ruff to permit the latest version.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
beea8cdBump 0.14.0 (#20751)416e956[ty] Infer better specializations of unions withNone(etc) (#20749)88c0ce3Update default and latest Python versions for 3.14 (#20725)8fb29ea[ruff] improve handling of intermixed comments inside from-imports (#20561)23ebfe7[ty] Fix tiny mistake in protocol tests (#20743)f90d646[ty] Makeinfer_method_informationless confusing (#20740)15af4c0Move --show-settings snapshots to separate files (#20741)76f8e5bRefactor Rust lint test structure to use RuffTestFixture (#20689)b66a3e7[refurb] Add fixes forFURB101,FURB103(#20520)70f51e9[ty] Printdisplayof types when a property test fails (#20720)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)