chore: Symfony UX 3 upgrade - #262
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s Symfony UX stack to the v3 line, aligning frontend tooling (Stimulus/Turbo) and related dependency metadata with the newer UX releases used by this Symfony 8.1 micro-framework template.
Changes:
- Bump
symfony/stimulus-bundleandsymfony/ux-turboto^3.0and refresh the lockfile accordingly. - Update Hotwired Turbo frontend asset to
8.0.23(importmap + vendored asset). - Extend UX Turbo controller configuration to autoimport the Mercure stream source element.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| importmap.php | Updates Turbo version and (per review) should include the new UX Turbo autoimport module mapping. |
| composer.json | Raises Symfony UX packages to v3-compatible constraints. |
| composer.lock | Locks updated UX-related dependency graph for the upgrade. |
| assets/controllers.json | Enables UX Turbo controller autoimport for Mercure stream support. |
| assets/vendor/installed.php | Updates vendored asset metadata (versions/order). |
| assets/vendor/@hotwired/turbo/turbo.index.js | Updates the vendored Turbo JS bundle to 8.0.23. |
Comments suppressed due to low confidence (1)
importmap.php:33
assets/controllers.jsonnow autoimports@symfony/ux-turbo/dist/mercure_stream_source_element.js, but this module specifier is not present in the importmap. Without an importmap entry, the browser will fail to resolve the module when Stimulus tries to autoimport it (runtime "Failed to resolve module specifier" error). Add it toimportmap.php(and ensure the asset exists in the asset map).
'@hotwired/turbo' => [
'version' => '8.0.23',
],
'@picocss/pico/css/pico.min.css' => [
'version' => '2.1.1',
'type' => 'css',
],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.