Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/consumer-repo/.github/workflows/agents-guard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
github.event_name == 'pull_request_target' &&
steps.eligibility.outputs.should-run == 'true' &&
steps.api_client_base.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@44965d8d784573c119fb63828c05c89256c5f3e1" # v1
uses: "stranske/Workflows/.github/actions/setup-api-client@a335f1af2c35b8f35d2278f56e9af78792a09bf1" # v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh the template-drift allowlist

When this consumer template changes, Health 74 Template Drift runs on templates/consumer-repo/.github/workflows/*.yml and compares the root/template pair against config/template-drift-allowlist.txt; the agents-guard.yml entry there still records the old template fingerprint (ff6f4a...) and reason for the previous 44965d8 pin, while this line changes the normalized template hash to 90fa914.... Any PR/push containing this commit will therefore report unallowlisted drift until the allowlist entry is re-baselined alongside the digest bump.

Useful? React with πŸ‘Β / πŸ‘Ž.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ“ Maintainability & Code Quality | 🟠 Major | πŸ—οΈ Heavy lift

Do not update agents-*.yml directly in the consumer template repo.

This file path is sync-managed, so this SHA bump should be done in stranske/Workflows and then synced back; direct local edits here risk drift and overwrite on next sync.

As per coding guidelines, "templates/consumer-repo/.github/workflows/agents-*.yml: Do not edit agents-*.yml workflows locally; fix issues in stranske/Workflows and sync back to this consumer repository" and "templates/consumer-repo/{.github/workflows/agents-*.yml,...} ... do not edit locally unless documented as repo-specific."

Also applies to: 183-183

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@templates/consumer-repo/.github/workflows/agents-guard.yml` at line 114, The
agents-guard.yml file in the consumer template repository is sync-managed from
the stranske/Workflows repository and should not be edited directly. Revert the
SHA changes made to the setup-api-client action reference (at line 114 and line
183) in this file back to their original state. Instead, make these updates in
the source stranske/Workflows repository where the agents-guard.yml workflow
template originates, and then trigger a sync operation to propagate the changes
back to this consumer repository to avoid drift and maintain consistency across
deployments.

Source: Coding guidelines

with:
secrets: ${{ toJSON(secrets) }}
github_token: ${{ github.token }}
Expand Down Expand Up @@ -180,7 +180,7 @@ jobs:
steps.eligibility.outputs.should-run == 'true' &&
github.event_name == 'pull_request' &&
steps.api_client_head.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@44965d8d784573c119fb63828c05c89256c5f3e1" # v1
uses: "stranske/Workflows/.github/actions/setup-api-client@a335f1af2c35b8f35d2278f56e9af78792a09bf1" # v1
with:
secrets: ${{ toJSON(secrets) }}
github_token: ${{ github.token }}
Expand Down
Loading