fix: keep template model registry fresh - #2719
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughUpdates the consumer-repo template configs: ChangesConsumer Template Config and Freshness Validation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Workflow source neededPR #2719 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
Automated Status SummaryHead SHA: 65e9def
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2abb41adb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "name": "slot2", | ||
| "provider": "anthropic", | ||
| "model": "claude-sonnet-4-6" | ||
| "quality_tier": "T5" |
There was a problem hiding this comment.
Avoid resolving the Anthropic slot to Opus
With this template, any consumer/new repo that has an Anthropic token and uses the default slot config no longer uses the documented Sonnet compare-mode default: load_slot_config() resolves a slot that has quality_tier but no model via select_model_for_tier(), and the current registry rates claude-opus-4-6 higher on T5 than claude-sonnet-4-6 while also marking Opus very expensive. I verified the templated config loads as SlotDefinition(... model='claude-opus-4-6'), so this silently shifts verifier/compare traffic to the most expensive Anthropic model rather than just avoiding a dominated-pin freshness finding.
Useful? React with 👍 / 👎.
Summary
Validation
Summary by CodeRabbit
Bug Fixes
Tests