fix: align dev version sync PR body - #2733
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 37 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Automated Status SummaryHead SHA: 27f325e
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
74fc0e9 to
870296b
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the maintenance workflow that opens “dev tool sync” PRs so the generated PR body accurately describes what was actually committed (pyproject vs. generated pin artifacts), and adds a regression test to prevent the copy from drifting again.
Changes:
- Update
maint-52-sync-dev-versions.ymlto compute the committed file set fromHEADand select a PR-scope sentence based on whetherpyproject.tomlis included. - Replace the previously hard-coded PR-scope paragraph in the PR body with the computed scope string.
- Add a new pytest regression test to validate key PR-body generation strings in the workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/maint-52-sync-dev-versions.yml |
Makes PR body scope conditional on whether pyproject.toml was actually changed in the commit. |
tests/workflows/test_maint52_sync_dev_versions_pr_body.py |
Adds regression coverage for the workflow’s PR body copy and changed-file detection logic. |
Comments suppressed due to low confidence (1)
tests/workflows/test_maint52_sync_dev_versions_pr_body.py:13
- The regression test asserts the conditional logic exists, but it doesn't currently verify that the computed
pr_scopeis actually interpolated into thepr_body. If${pr_scope}stops being used (or is accidentally replaced by a hard-coded paragraph), this test would still pass while the PR body regresses.
assert "grep -qx 'pyproject.toml'" in text
assert "generated dev-tool pin files" in text
assert "This PR updates dev tool versions in \\`pyproject.toml\\` to match" not in text
|
Runner dispatch state for codex on PR #2733. Do not edit. |
Summary
Validation