Skip to content

fix: align dev version sync PR body - #2733

Merged
stranske merged 2 commits into
mainfrom
codex/fix-maint52-pr-body-copy
Jul 7, 2026
Merged

fix: align dev version sync PR body#2733
stranske merged 2 commits into
mainfrom
codex/fix-maint52-pr-body-copy

Conversation

@stranske

@stranske stranske commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • make Maint 52 dev-tool-sync PR descriptions match the actual committed file set
  • avoid claiming pyproject.toml changed for repos that only receive generated env/lockfile updates
  • add a focused regression test for the generated body copy

Validation

  • PYTHONPYCACHEPREFIX=/tmp/codex-pycache-sync-closer-clean python3 -m pytest tests/workflows/test_maint52_sync_dev_versions_pr_body.py -q
  • PYTHONPYCACHEPREFIX=/tmp/codex-pycache-sync-closer-clean python3 scripts/validate_template_completeness.py
  • PYTHONPYCACHEPREFIX=/tmp/codex-pycache-sync-closer-clean python3 scripts/validate_template_sync.py
  • git diff --check

Copilot AI review requested due to automatic review settings July 7, 2026 08:31
@stranske stranske added codex codex-automation automation Automation and workflow automation maintenance Maintenance tasks dependencies Dependency updates labels Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 37 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8ad7525b-5cdc-4a52-83d1-0a2fb77e0ed5

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528fc and 60f97e0.

📒 Files selected for processing (2)
  • .github/workflows/maint-52-sync-dev-versions.yml
  • tests/workflows/test_maint52_sync_dev_versions_pr_body.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-maint52-pr-body-copy

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske temporarily deployed to agent-standard July 7, 2026 08:31 — with GitHub Actions Inactive
@stranske
stranske enabled auto-merge (squash) July 7, 2026 08:31
@stranske
stranske temporarily deployed to agent-standard July 7, 2026 08:32 — with GitHub Actions Inactive
@stranske-keepalive

stranske-keepalive Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 27f325e
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 75.69%
Baseline 85.00%
Delta -9.31%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 77
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/ci_failure_triage.py 44.2% 123
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 77
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/ci_failure_triage.py 44.2% 123
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske force-pushed the codex/fix-maint52-pr-body-copy branch from 74fc0e9 to 870296b Compare July 7, 2026 08:33
@stranske
stranske temporarily deployed to agent-high-privilege July 7, 2026 08:34 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the maintenance workflow that opens “dev tool sync” PRs so the generated PR body accurately describes what was actually committed (pyproject vs. generated pin artifacts), and adds a regression test to prevent the copy from drifting again.

Changes:

  • Update maint-52-sync-dev-versions.yml to compute the committed file set from HEAD and select a PR-scope sentence based on whether pyproject.toml is included.
  • Replace the previously hard-coded PR-scope paragraph in the PR body with the computed scope string.
  • Add a new pytest regression test to validate key PR-body generation strings in the workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/maint-52-sync-dev-versions.yml Makes PR body scope conditional on whether pyproject.toml was actually changed in the commit.
tests/workflows/test_maint52_sync_dev_versions_pr_body.py Adds regression coverage for the workflow’s PR body copy and changed-file detection logic.
Comments suppressed due to low confidence (1)

tests/workflows/test_maint52_sync_dev_versions_pr_body.py:13

  • The regression test asserts the conditional logic exists, but it doesn't currently verify that the computed pr_scope is actually interpolated into the pr_body. If ${pr_scope} stops being used (or is accidentally replaced by a hard-coded paragraph), this test would still pass while the PR body regresses.
    assert "grep -qx 'pyproject.toml'" in text
    assert "generated dev-tool pin files" in text
    assert "This PR updates dev tool versions in \\`pyproject.toml\\` to match" not in text

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Runner dispatch state for codex on PR #2733. Do not edit.

@stranske
stranske temporarily deployed to agent-high-privilege July 7, 2026 08:45 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-standard July 7, 2026 08:46 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-standard July 7, 2026 08:46 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-high-privilege July 7, 2026 10:31 — with GitHub Actions Inactive
@stranske
stranske merged commit 001bfed into main Jul 7, 2026
50 checks passed
@stranske
stranske deleted the codex/fix-maint52-pr-body-copy branch July 7, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autofix:escalated automation Automation and workflow automation codex codex-automation dependencies Dependency updates maintenance Maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants