Skip to content

fix: restore backplane reference artifact - #2763

Merged
stranske merged 8 commits into
mainfrom
codex/fix-backplane-conformance-artifact-handoff
Jul 12, 2026
Merged

fix: restore backplane reference artifact#2763
stranske merged 8 commits into
mainfrom
codex/fix-backplane-conformance-artifact-handoff

Conversation

@stranske

@stranske stranske commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • restore the caller-emitted reference-run artifact before reusable conformance validation
  • make the artifact name configurable, defaulting to the existing caller contract
  • document and test the cross-job handoff

Root cause

Pension-Data #712 emitted a valid run envelope and manifest, but the reusable workflow runs in a fresh job and previously validated paths that were never downloaded.

Validation

  • python scripts/validate_workflow_yaml.py .github/workflows/reusable-backplane-conformance.yml
  • focused workflow and backplane-contract tests (30 passed)
  • Ruff, Black, and git diff --check

Unblocks the retry path for stranske/Pension-Data#712.

Summary by CodeRabbit

  • New Features
    • Added support for restoring a configurable reference-run artifact during conformance validation.
    • The reference artifact name is now optional/configurable, defaulting to reference-run.
  • Documentation
    • Added a “Reference-run artifact handoff” guide covering how to package, upload, restore, and validate reference-run artifacts.
  • Tests
    • Added tests that verify the reusable workflow’s configuration for restoring the reference run into artifacts/reference.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The reusable conformance workflow now restores a caller-uploaded reference artifact before validation, supports a configurable artifact name, documents the handoff contract, and adds a test for the workflow configuration. Recorded attempt metadata is also updated.

Changes

Reference Artifact Handoff

Layer / File(s) Summary
Configure and restore the reference artifact
.github/workflows/reusable-backplane-conformance.yml
Adds the optional reference_artifact_name input, downloads the named artifact to artifacts/reference, and reformats conformance violation detail construction.
Document and test the handoff
docs/contracts/research-backplane-contract.md, tests/workflows/test_backplane_conformance_artifact_handoff.py
Documents the reference-run artifact flow and verifies the workflow’s artifact input, download action, and destination path.

Attempt Metadata Update

Layer / File(s) Summary
Update recorded attempt metadata
langsmith-fleet-worker-attempt.json
Updates the emitted timestamp and pull request number while retaining the other attempt metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CallerJob
  participant ReusableWorkflow
  participant ConformanceValidator
  CallerJob->>ReusableWorkflow: Provide reference_artifact_name
  ReusableWorkflow->>ReusableWorkflow: Download artifact to artifacts/reference
  ReusableWorkflow->>ConformanceValidator: Run validation using restored reference files
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: restoring the backplane reference artifact.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-backplane-conformance-artifact-handoff

Comment @coderabbitai help to get the list of available commands.

@agents-workflows-bot

Copy link
Copy Markdown
Contributor

Workflow source needed

PR #2763 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

  • Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
  • Check one Workflow Source option in the PR body.
  • Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
  • Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

@stranske
stranske marked this pull request as ready for review July 11, 2026 22:27
Copilot AI review requested due to automatic review settings July 11, 2026 22:27
@stranske
stranske temporarily deployed to agent-standard July 11, 2026 22:27 — with GitHub Actions Inactive
@agents-workflows-bot

agents-workflows-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 363b9e0
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 75.68%
Baseline 85.00%
Delta -9.32%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/ci_failure_triage.py 44.2% 123
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/ci_failure_triage.py 44.2% 123
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb70167a5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/reusable-backplane-conformance.yml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/reusable-backplane-conformance.yml:
- Around line 76-83: Make the “Restore emitted reference run” download step
conditional on the reference artifact being present, using the workflow’s
existing artifact-presence or emission signal. Ensure repositories that skip
emission via if-no-files-found: ignore bypass the download and allow the
validator’s existing skip behavior to run.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e412aad-d451-4d2c-8d18-a0b77c2bf94a

📥 Commits

Reviewing files that changed from the base of the PR and between 5aa070b and fb70167.

📒 Files selected for processing (3)
  • .github/workflows/reusable-backplane-conformance.yml
  • docs/contracts/research-backplane-contract.md
  • tests/workflows/test_backplane_conformance_artifact_handoff.py

Comment thread .github/workflows/reusable-backplane-conformance.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the cross-job handoff for backplane conformance by explicitly downloading the caller-emitted reference-run artifact before running the canonical validate_run_contract.py validator, and adds documentation + a regression test for that contract.

Changes:

  • Add a reference_artifact_name workflow_call input (defaulting to reference-run) and download that artifact into artifacts/reference before validation.
  • Document the reference-run artifact handoff in the research backplane contract doc.
  • Add a test that asserts the reusable workflow contains the artifact-restore step and input.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/workflows/test_backplane_conformance_artifact_handoff.py Adds a regression test for the artifact restore/input contract in the reusable workflow.
docs/contracts/research-backplane-contract.md Documents the caller→reusable workflow artifact handoff.
.github/workflows/reusable-backplane-conformance.yml Restores the caller-emitted reference artifact before running conformance validation; adds a configurable artifact name input.

Comment thread .github/workflows/reusable-backplane-conformance.yml
Comment thread tests/workflows/test_backplane_conformance_artifact_handoff.py
Comment thread docs/contracts/research-backplane-contract.md Outdated
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Runner dispatch state for codex on PR #2763. Do not edit.

@stranske
stranske temporarily deployed to agent-high-privilege July 11, 2026 22:39 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-standard July 11, 2026 22:39 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-high-privilege July 11, 2026 22:56 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-standard July 11, 2026 22:56 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-high-privilege July 11, 2026 23:23 — with GitHub Actions Inactive
@stranske
stranske temporarily deployed to agent-high-privilege July 12, 2026 00:25 — with GitHub Actions Inactive
@stranske

Copy link
Copy Markdown
Owner Author

Resolved the artifact-absence review set in e9c6dce. The restore step now uses continue-on-error: true, so non-emitting/planned callers reach the validator’s established opt-in skip path; emitting participants still fail there when their required envelope is absent. Updated the contract docs and regression assertion. Validation: uv run pytest tests/workflows/test_backplane_conformance_artifact_handoff.py tests/scripts/test_check_gate_diff_quality.py -q (7 passed), workflow YAML validation, and check_gate_diff_quality.py passed.

@stranske
stranske merged commit 6391edf into main Jul 12, 2026
56 checks passed
@stranske
stranske deleted the codex/fix-backplane-conformance-artifact-handoff branch July 12, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants