fix: restore backplane reference artifact - #2763
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe reusable conformance workflow now restores a caller-uploaded reference artifact before validation, supports a configurable artifact name, documents the handoff contract, and adds a test for the workflow configuration. Recorded attempt metadata is also updated. ChangesReference Artifact Handoff
Attempt Metadata Update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CallerJob
participant ReusableWorkflow
participant ConformanceValidator
CallerJob->>ReusableWorkflow: Provide reference_artifact_name
ReusableWorkflow->>ReusableWorkflow: Download artifact to artifacts/reference
ReusableWorkflow->>ConformanceValidator: Run validation using restored reference files
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Workflow source neededPR #2763 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
Automated Status SummaryHead SHA: 363b9e0
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb70167a5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/reusable-backplane-conformance.yml:
- Around line 76-83: Make the “Restore emitted reference run” download step
conditional on the reference artifact being present, using the workflow’s
existing artifact-presence or emission signal. Ensure repositories that skip
emission via if-no-files-found: ignore bypass the download and allow the
validator’s existing skip behavior to run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3e412aad-d451-4d2c-8d18-a0b77c2bf94a
📒 Files selected for processing (3)
.github/workflows/reusable-backplane-conformance.ymldocs/contracts/research-backplane-contract.mdtests/workflows/test_backplane_conformance_artifact_handoff.py
There was a problem hiding this comment.
Pull request overview
This PR restores the cross-job handoff for backplane conformance by explicitly downloading the caller-emitted reference-run artifact before running the canonical validate_run_contract.py validator, and adds documentation + a regression test for that contract.
Changes:
- Add a
reference_artifact_nameworkflow_callinput (defaulting toreference-run) and download that artifact intoartifacts/referencebefore validation. - Document the reference-run artifact handoff in the research backplane contract doc.
- Add a test that asserts the reusable workflow contains the artifact-restore step and input.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/workflows/test_backplane_conformance_artifact_handoff.py |
Adds a regression test for the artifact restore/input contract in the reusable workflow. |
docs/contracts/research-backplane-contract.md |
Documents the caller→reusable workflow artifact handoff. |
.github/workflows/reusable-backplane-conformance.yml |
Restores the caller-emitted reference artifact before running conformance validation; adds a configurable artifact name input. |
|
Runner dispatch state for codex on PR #2763. Do not edit. |
|
Resolved the artifact-absence review set in e9c6dce. The restore step now uses |
Summary
reference-runartifact before reusable conformance validationRoot cause
Pension-Data #712 emitted a valid run envelope and manifest, but the reusable workflow runs in a fresh job and previously validated paths that were never downloaded.
Validation
python scripts/validate_workflow_yaml.py .github/workflows/reusable-backplane-conformance.ymlgit diff --checkUnblocks the retry path for stranske/Pension-Data#712.
Summary by CodeRabbit
reference-run.artifacts/reference.