fix(llm): run model evaluation pilot as a module - #2766
Conversation
GitHub Actions
Inactive
Workflow source neededPR #2766 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 51 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe model evaluation pilot workflow now invokes its module form, handles missing result artifacts without failing summary or upload steps, and adds a test asserting these workflow settings. ChangesModel evaluation pilot
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes the model evaluation pilot workflow execution by invoking the pilot runner as an importable module (python -m ...) so the repository root stays on sys.path, preventing ModuleNotFoundError failures from incorrect module resolution. It also hardens the always-run post-steps so missing result artifacts are reported clearly without overriding the original failure signal.
Changes:
- Update the pilot workflow to run
tools.run_model_eval_pilotviapython -m ...instead of executing the file path directly. - Add an always-run summary guard that writes an explicit “missing results artifact” message when
pilot-results.jsonwas not produced. - Add a workflow contract test to lock in the intended invocation and missing-artifact handling behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/maint-78-model-evaluation-pilot.yml |
Switches the pilot runner to module execution and improves always-run summary/artifact steps when results are missing. |
tests/workflows/test_model_eval_pilot_workflow.py |
Adds a contract test asserting the workflow uses module invocation and warns (not errors) on missing artifacts. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/workflows/test_model_eval_pilot_workflow.py`:
- Around line 4-13: Update test_model_eval_pilot_runs_as_importable_module to
inspect the workflow’s summary and upload step blocks individually, asserting
each contains if: always() alongside its relevant command or configuration.
Replace whole-file substring checks for pilot-results.json and
if-no-files-found: warn with step-scoped assertions or structured YAML parsing,
while preserving the existing module-invocation checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 94db0db3-bd3c-4a93-9b51-98841821f2a3
📒 Files selected for processing (2)
.github/workflows/maint-78-model-evaluation-pilot.ymltests/workflows/test_model_eval_pilot_workflow.py
Automated Status SummaryHead SHA: 6820b9f
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
GitHub Actions
Inactive
GitHub Actions
Inactive
Follow-up to #2740 and failed pilot run #29220735966.
The workflow invoked
tools/run_model_eval_pilot.pyas a file, which placedtools/rather than the repository root onsys.pathand causedModuleNotFoundError: scripts. This changes the command topython -m tools.run_model_eval_pilot, adds a workflow contract test, and makes the always-run summary/upload steps report a missing result artifact without masking the root execution failure.Validation:
3 passedfor the workflow contract and pilot runner testsSummary by CodeRabbit
Bug Fixes
Tests