Skip to content

fix: tolerate missing durable tracker labels - #2772

Merged
stranske merged 3 commits into
mainfrom
fix/sync-review-debt-july14b
Jul 14, 2026
Merged

fix: tolerate missing durable tracker labels#2772
stranske merged 3 commits into
mainfrom
fix/sync-review-debt-july14b

Conversation

@stranske

Copy link
Copy Markdown
Owner

Fixes shared sync review debt from trip-planner#1522 and Manager-Database#1413. Renames the agent registry local filepath variable and only applies tracker:durable when the consumer repository provides that label. Refreshes the intentional root/template drift baseline.

Copilot AI review requested due to automatic review settings July 14, 2026 08:31
@stranske
stranske temporarily deployed to agent-high-privilege July 14, 2026 08:32 — with GitHub Actions Inactive
@agents-workflows-bot

Copy link
Copy Markdown
Contributor

Workflow source needed

PR #2772 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

  • Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
  • Check one Workflow Source option in the PR body.
  • Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
  • Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

@stranske stranske added codex codex-automation automation Automation and workflow automation maintenance Maintenance tasks sync labels Jul 14, 2026
@stranske
stranske enabled auto-merge (squash) July 14, 2026 08:32
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (7)
  • sync
  • workflow:source-sync
  • workflow:source-maintenance
  • consumer-sync
  • integration-sync
  • workflows-sync
  • template-sync

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 338011de-b873-44ab-9f46-9f66d57b7f35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sync-review-debt-july14b

Comment @coderabbitai help to get the list of available commands.

@stranske-keepalive

stranske-keepalive Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 3fa20ae
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske temporarily deployed to agent-high-privilege July 14, 2026 08:32 — with GitHub Actions Inactive

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41b880485e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread config/template-drift-allowlist.txt Outdated
main = .github/workflows/agents-weekly-metrics.yml
template = templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml
main_sha256 = 3636b71e9b0e1aa8032fdbc04ff2c9269627c4c1d1adf05db0d323c6896c9db4
main_sha256 = 152a66c3c5e9ce08b8f7dc8f4699e016af139eae8f3d48c621fae0ebf4f240b0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Port the label guard to the consumer template

Refreshing this drift fingerprint after the tracker:durable fix hides that the managed consumer template still unconditionally creates/adds tracker:durable in templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml. Because .github/sync-manifest.yml includes agents-weekly-metrics.yml as a consumer-facing workflow, new repos cloned from the template, or any template-based refresh, will still fail in repositories that do not define that label—the same scenario this commit fixes in the root workflow. Please apply the same listLabelsForRepo guard to the template while preserving its pinned-action differences, rather than only re-baselining the root/template drift.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce shared fleet sync review debt by (1) clarifying the agent registry file-path variable name in both root and consumer template scripts, and (2) making the weekly metrics tracking issue labeling resilient when tracker:durable is not defined in a repository, while also refreshing the workflow/template drift allowlist baseline.

Changes:

  • Rename the local agent registry file path variable to registryFilePath in both the root and consumer template agent_registry.js.
  • Update the root agents-weekly-metrics workflow to only apply tracker:durable if the repo defines that label.
  • Refresh the template drift allowlist hash for agents-weekly-metrics.yml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/agents-weekly-metrics.yml Adds a repo-label existence check to avoid applying tracker:durable when absent.
.github/scripts/agent_registry.js Renames the local registry filepath variable for clarity/avoidance of path shadowing.
templates/consumer-repo/.github/scripts/agent_registry.js Mirrors the same registry filepath rename in the consumer template.
config/template-drift-allowlist.txt Updates the stored SHA for the root weekly-metrics workflow drift baseline.

Comment on lines +415 to +417
labels: hasDurableTrackerLabel
? ['tracker:durable', 'automated']
: ['automated'],
@stranske
stranske force-pushed the fix/sync-review-debt-july14b branch from 76dddde to b1f07b8 Compare July 14, 2026 12:29
@stranske
stranske temporarily deployed to agent-high-privilege July 14, 2026 12:29 — with GitHub Actions Inactive
@stranske
stranske merged commit ffca68a into main Jul 14, 2026
45 checks passed
@stranske
stranske deleted the fix/sync-review-debt-july14b branch July 14, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Automation and workflow automation codex codex-automation maintenance Maintenance tasks sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants