fix: tolerate missing durable tracker labels - #2772
Conversation
Workflow source neededPR #2772 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Automated Status SummaryHead SHA: 3fa20ae
Coverage Overview
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41b880485e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| main = .github/workflows/agents-weekly-metrics.yml | ||
| template = templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml | ||
| main_sha256 = 3636b71e9b0e1aa8032fdbc04ff2c9269627c4c1d1adf05db0d323c6896c9db4 | ||
| main_sha256 = 152a66c3c5e9ce08b8f7dc8f4699e016af139eae8f3d48c621fae0ebf4f240b0 |
There was a problem hiding this comment.
Port the label guard to the consumer template
Refreshing this drift fingerprint after the tracker:durable fix hides that the managed consumer template still unconditionally creates/adds tracker:durable in templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml. Because .github/sync-manifest.yml includes agents-weekly-metrics.yml as a consumer-facing workflow, new repos cloned from the template, or any template-based refresh, will still fail in repositories that do not define that label—the same scenario this commit fixes in the root workflow. Please apply the same listLabelsForRepo guard to the template while preserving its pinned-action differences, rather than only re-baselining the root/template drift.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce shared fleet sync review debt by (1) clarifying the agent registry file-path variable name in both root and consumer template scripts, and (2) making the weekly metrics tracking issue labeling resilient when tracker:durable is not defined in a repository, while also refreshing the workflow/template drift allowlist baseline.
Changes:
- Rename the local agent registry file path variable to
registryFilePathin both the root and consumer templateagent_registry.js. - Update the root
agents-weekly-metricsworkflow to only applytracker:durableif the repo defines that label. - Refresh the template drift allowlist hash for
agents-weekly-metrics.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/agents-weekly-metrics.yml |
Adds a repo-label existence check to avoid applying tracker:durable when absent. |
.github/scripts/agent_registry.js |
Renames the local registry filepath variable for clarity/avoidance of path shadowing. |
templates/consumer-repo/.github/scripts/agent_registry.js |
Mirrors the same registry filepath rename in the consumer template. |
config/template-drift-allowlist.txt |
Updates the stored SHA for the root weekly-metrics workflow drift baseline. |
| labels: hasDurableTrackerLabel | ||
| ? ['tracker:durable', 'automated'] | ||
| : ['automated'], |
76dddde to
b1f07b8
Compare
Fixes shared sync review debt from trip-planner#1522 and Manager-Database#1413. Renames the agent registry local filepath variable and only applies
tracker:durablewhen the consumer repository provides that label. Refreshes the intentional root/template drift baseline.