fix: sync all dev dependency pin surfaces - #2790
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
GitHub Actions
Inactive
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 50 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workflow now refreshes and stages ChangesDev version synchronization
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant SyncWorkflow
participant ConsumerRepo
participant uv
participant SyncPR
SyncWorkflow->>ConsumerRepo: apply dev dependency updates
SyncWorkflow->>uv: run uv lock --check
uv->>ConsumerRepo: refresh uv.lock
SyncWorkflow->>SyncPR: stage uv.lock when present
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/maint-52-sync-dev-versions.yml:
- Around line 204-207: Update both dependency-sync branches in the workflow so
the apply command’s failure causes the step to fail rather than being swallowed.
Only execute the uv lock command after that apply command succeeds, ensuring a
successful lock refresh cannot mask a partial dependency sync.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 030e5114-0f95-4705-8389-34076d7ad46a
📒 Files selected for processing (3)
.github/workflows/maint-52-sync-dev-versions.ymlscripts/sync_dev_dependencies.pytests/scripts/test_sync_dev_dependencies.py
There was a problem hiding this comment.
Pull request overview
This PR expands the dev-dependency pin synchronization surfaces so that direct dev requirement files (requirements-dev.txt) stay aligned with the canonical pin source (.github/workflows/autofix-versions.env), and ensures Maint-52’s sync workflow can also refresh uv.lock when applying changes.
Changes:
- Extend
sync_dev_dependencies.pyto includerequirements-dev.txtamong the supported pin-update surfaces. - Update the sync script test to assert
requirements-dev.txtis updated during--apply. - Update
maint-52-sync-dev-versions.ymlto (a) refreshuv.lockviauv lockwhen present and (b) includerequirements-dev.txtanduv.lockin the generated PR commit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/scripts/test_sync_dev_dependencies.py |
Adds coverage for syncing requirements-dev.txt during apply mode. |
scripts/sync_dev_dependencies.py |
Adds requirements-dev.txt to the set of files whose exact == pins are synced from the canonical env pins. |
.github/workflows/maint-52-sync-dev-versions.yml |
Refreshes uv.lock when present and stages requirements-dev.txt + uv.lock in Maint-52 generated PRs. |
| if [ "${{ inputs.dry_run }}" != "true" ] && [ -f uv.lock ]; then | ||
| python -m pip install --disable-pip-version-check 'uv>=0.5' | ||
| uv lock | ||
| fi |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca9bd3352
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Automated Status SummaryHead SHA: 498ad85
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
GitHub Actions
Inactive
GitHub Actions
Inactive
Summary
Validation
Summary by CodeRabbit
uvlockfiles when applying updates, including running lockfile checks to ensure changes are captured.uvlockfiles when present.uv lock --checkbefore updating.