docs: clarify LLM slot bootstrap condition by stranske · Pull Request #2798 · stranske/Workflows

stranske · 2026-07-20T14:30:32Z

Clarifies the fail-closed bootstrap condition in the canonical registry and synchronized consumer template.\n\nValidation: python -m pytest tests/tools/test_langchain_client.py tests/tools/test_llm_registry_selection.py -q (82 passed); python scripts/validate_template_sync.py.

Summary by CodeRabbit

Documentation
- Clarified the conditions under which a runtime model override is retained during emergency bootstrap.
- Documented that, when an explicit slot allowlist or the bundled default slot file is available, the system returns an empty, fail-closed slot set.
- No user-facing behavior or functionality changed.

cursor · 2026-07-20T14:30:36Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

coderabbitai · 2026-07-20T14:31:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 751d3999-92a3-4abd-928f-bc6b067e64bf

📥 Commits

Reviewing files that changed from the base of the PR and between 97a2f6b and 016f73e.

📒 Files selected for processing (2)

templates/consumer-repo/tools/llm_registry.py
tools/llm_registry.py

📝 Walkthrough

Walkthrough

Updated the resolve_slots comments in the template and primary registry files to clarify the emergency bootstrap condition. No functional logic or control flow changed.

Changes

Resolve-slots comment synchronization

Layer / File(s)	Summary
Update resolve-slots documentation `templates/consumer-repo/tools/llm_registry.py`, `tools/llm_registry.py`	Comments now describe preserving `LANGCHAIN_MODEL` only when no explicit allowlist or bundled default slot file is available. Runtime behavior remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

stranske/Workflows#2797: Introduces the slot-allowlist behavior documented by these comment updates.

Suggested labels: maintenance, sync

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the comment-only clarification of the LLM slot bootstrap condition.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/clarify-slot-bootstrap-condition

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

This PR clarifies the documented “fail-closed” / emergency-bootstrap behavior for LLM slot resolution in the canonical LLM registry helper, and mirrors the same clarification into the synchronized consumer template to prevent drift.

Changes:

Updates the resolve_slots() inline comment to state the runtime override bootstrap is only used when no slot allowlist is configured.
Applies the same comment update in templates/consumer-repo/ to keep consumer templates aligned.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tools/llm_registry.py	Adjusts the inline documentation describing the bootstrap condition for slot resolution.
templates/consumer-repo/tools/llm_registry.py	Mirrors the same documentation change into the consumer template copy to avoid drift.

+    # Preserve an explicit runtime override as an emergency bootstrap only when
+    # no slot allowlist is configured. Empty models are never invoked directly;


+    # Preserve an explicit runtime override as an emergency bootstrap only when
+    # no slot allowlist is configured. Empty models are never invoked directly;


stranske-keepalive · 2026-07-20T16:28:49Z

Workflow source needed

PR #2798 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

Add  or a normal Closes #123 / Related to #123 line.
Check one Workflow Source option in the PR body.
Add a hidden marker such as , , , , or .
Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

stranske-keepalive · 2026-07-20T16:36:16Z

Automated Status Summary

Head SHA: efdd2c3
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job	Result	Logs
(no jobs reported)	⏳ pending	—

Coverage Overview

Coverage history entries: 1

Coverage Trend

Metric	Value
Current	75.71%
Baseline	85.00%
Delta	-9.29%
Minimum	70.00%
Status	✅ Pass

Top Coverage Hotspots (lowest coverage)

File	Coverage	Missing
`scripts/issue_dedup_smoke.py`	0.0%	4
`scripts/runner_lib/__main__.py`	0.0%	3
`scripts/validate_template_sync.py`	0.0%	81
`scripts/langchain/topic_splitter.py`	19.1%	57
`tools/codex_log_analyzer.py`	19.6%	140
`scripts/repo_review_round2_runner.py`	25.1%	344
`scripts/prune_agent_stubs.py`	39.7%	26
`scripts/repo_review_round1_runner.py`	40.7%	133
`tools/ensure_workflow_timeout_variables.py`	42.1%	74
`scripts/sync_label_docs.py`	42.9%	64
`tools/discover_model_catalog.py`	44.8%	55
`scripts/repo_review_backlog_scan.py`	45.3%	116
`scripts/repo_review_body_writer.py`	46.5%	86
`tools/codex_session_analyzer.py`	47.9%	59
`scripts/create_verifier_labels.py`	48.3%	58

Low Coverage Files (<50.0%)

File	Coverage	Missing
`scripts/issue_dedup_smoke.py`	0.0%	4
`scripts/runner_lib/__main__.py`	0.0%	3
`scripts/validate_template_sync.py`	0.0%	81
`scripts/langchain/topic_splitter.py`	19.1%	57
`tools/codex_log_analyzer.py`	19.6%	140
`scripts/repo_review_round2_runner.py`	25.1%	344
`scripts/prune_agent_stubs.py`	39.7%	26
`scripts/repo_review_round1_runner.py`	40.7%	133
`tools/ensure_workflow_timeout_variables.py`	42.1%	74
`scripts/sync_label_docs.py`	42.9%	64
`tools/discover_model_catalog.py`	44.8%	55
`scripts/repo_review_backlog_scan.py`	45.3%	116
`scripts/repo_review_body_writer.py`	46.5%	86
`tools/codex_session_analyzer.py`	47.9%	59
`scripts/create_verifier_labels.py`	48.3%	58

Updated automatically; will refresh on subsequent CI/Docker completions.

Keepalive checklist

Scope

No scope information available

Tasks

No tasks defined

Acceptance criteria

No acceptance criteria defined

Copilot AI review requested due to automatic review settings July 20, 2026 14:30

Copilot started reviewing on behalf of stranske July 20, 2026 14:31 View session

Copilot AI reviewed Jul 20, 2026

View reviewed changes

docs: clarify LLM slot bootstrap condition

016f73e

stranske force-pushed the fix/clarify-slot-bootstrap-condition branch from 97a2f6b to 016f73e Compare July 20, 2026 16:28

stranske temporarily deployed to agent-standard July 20, 2026 16:28 — with GitHub Actions Inactive

stranske merged commit d8ab9e7 into main Jul 20, 2026
54 checks passed

stranske deleted the fix/clarify-slot-bootstrap-condition branch July 20, 2026 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: clarify LLM slot bootstrap condition - #2798

docs: clarify LLM slot bootstrap condition#2798
stranske merged 1 commit into
mainfrom
fix/clarify-slot-bootstrap-condition

stranske commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cursor Bot commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Uh oh!

stranske-keepalive Bot commented Jul 20, 2026

Uh oh!

stranske-keepalive Bot commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		# Preserve an explicit runtime override as an emergency bootstrap only when
		# no slot allowlist is configured. Empty models are never invoked directly;

Conversation

stranske commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

cursor Bot commented Jul 20, 2026

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

stranske-keepalive Bot commented Jul 20, 2026

Workflow source needed

Uh oh!

stranske-keepalive Bot commented Jul 20, 2026

Automated Status Summary

Coverage Overview

Coverage Trend

Top Coverage Hotspots (lowest coverage)

Low Coverage Files (<50.0%)

Keepalive checklist

Scope

Tasks

Acceptance criteria

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stranske commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading