Skip to content

chore(model-eval): refresh verifier pilot candidates to current catalog (add claude-opus-4-8) - #2818

Merged
stranske merged 1 commit into
mainfrom
model-eval-candidates-refresh
Jul 24, 2026
Merged

chore(model-eval): refresh verifier pilot candidates to current catalog (add claude-opus-4-8)#2818
stranske merged 1 commit into
mainfrom
model-eval-candidates-refresh

Conversation

@stranske

Copy link
Copy Markdown
Owner

What

Refresh the verifier-pilot candidate set (config/model_eval_candidates.json) to match the current catalog.

It had drifted: it listed claude-sonnet-4-6 (no longer in the model catalog) and omitted claude-opus-4-8 — the current high-capability Anthropic model that supersedes the claude-opus-4-6 incumbent verifier. So a maint-78 pilot could not test the model that actually supersedes the incumbent, and risked a preflight abort on the defunct sonnet-4-6.

  • anthropic: + claude-opus-4-8 (candidate), claude-sonnet-4-6claude-sonnet-5 (candidate); claude-opus-4-6 stays incumbent.
  • openai: unchanged (already lists gpt-5.6-terra, gpt-5.6-sol candidates vs gpt-5.4 incumbent).
  • Candidates only gate what gets benchmarked, not what's selected — selection still requires the paired-corpus gates + human approval per MODEL_SELECTION_POLICY.md.

Why now

Surfaced while validating that the verifier-balanced selections (still on the superseded opus-4-6/gpt-5.4 incumbents) can actually be re-evaluated against current models. The candidate-file drift is a concrete instance of the broader "catalog-only evidence can never promote; the manual eval never runs" gap — tracked separately as a design issue.

Verification

Valid JSON; maint-78 dispatched against this branch to run the paired 30-case narrowing pilot with claude-opus-4-8 + gpt-5.6-terra/sol as candidates.

🤖 Generated with Claude Code

The candidate set drifted from the catalog: it listed claude-sonnet-4-6 (no
longer catalogued) and omitted claude-opus-4-8 (the current high-capability
Anthropic model that supersedes the opus-4-6 incumbent). Add claude-opus-4-8 +
claude-sonnet-5 as candidates and drop the defunct sonnet-4-6 so maint-78 tests
the models that actually supersede the incumbents. OpenAI already lists the
gpt-5.6 candidates. Candidates only gate what gets benchmarked, not selection.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 24 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 97345721-e2c4-4ec3-882e-ceb7ab1ac4c8

📥 Commits

Reviewing files that changed from the base of the PR and between b1054df and 75e0cc0.

📒 Files selected for processing (1)
  • config/model_eval_candidates.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch model-eval-candidates-refresh

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske temporarily deployed to agent-standard July 24, 2026 17:15 — with GitHub Actions Inactive
@stranske-keepalive

Copy link
Copy Markdown
Contributor

Workflow source needed

PR #2818 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

  • Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
  • Check one Workflow Source option in the PR body.
  • Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
  • Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

@stranske-keepalive

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 5b60aa7
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75e0cc0f78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +7 to +8
{"provider":"anthropic","model_id":"claude-opus-4-8","role":"candidate"},
{"provider":"anthropic","model_id":"claude-sonnet-5","role":"candidate"},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove Claude candidates until sampling params are handled

When maint-78-model-evaluation-pilot.yml runs the default candidate file, each row is passed through tools.run_model_eval_pilot into pr_verifier.evaluate_pr, whose Anthropic client still sends temperature=0.1 on every request. Anthropic documents that Claude Opus 4.8 / Claude 4.7+ and Claude Sonnet 5 reject non-default sampling parameters with a 400 (docs), so these newly-added candidates will return errors, be marked schema_valid: false, and make unusable_candidates() abort the pilot during preflight instead of producing the intended benchmark. Update the client to omit sampling params for these models before adding them here.

Useful? React with 👍 / 👎.

@stranske
stranske merged commit 5eb4200 into main Jul 24, 2026
38 of 39 checks passed
@stranske
stranske deleted the model-eval-candidates-refresh branch July 24, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant