Skip to content

fix(scripts): drop dead run_tests.sh recommendation from check_test_dependencies.sh - #2835

Merged
stranske merged 1 commit into
mainfrom
fix/llm-safety-consumer-test-reds
Jul 26, 2026
Merged

fix(scripts): drop dead run_tests.sh recommendation from check_test_dependencies.sh#2835
stranske merged 1 commit into
mainfrom
fix/llm-safety-consumer-test-reds

Conversation

@stranske

Copy link
Copy Markdown
Owner

What

scripts/check_test_dependencies.sh recommended ./scripts/run_tests.sh, which exists in no repo in the fleet. Consumers that sync this file and run the dependency-setup validator (e.g. Manager-Database's check_dependency_script_recommendations) fail because the recommended script path does not exist.

Recommend python -m pytest unconditionally.

Why

Source-of-truth fix so the re-synced copies in Manager-Database / Inv-Man-Intake stay in sync. No behavior change beyond the recommendation text; Workflows' own validator does not check this helper.

🤖 Generated with Claude Code

…ependencies.sh

The helper recommended ./scripts/run_tests.sh, which exists in no repo in the
fleet. Consumers that sync this file and run the dependency-setup validator
(e.g. Manager-Database) fail because the recommended script path does not exist.
Recommend `python -m pytest` unconditionally.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 26, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6ddb9088-5292-4347-9f36-10446f8db020

📥 Commits

Reviewing files that changed from the base of the PR and between 9d719c0 and 88a3c57.

📒 Files selected for processing (1)
  • scripts/check_test_dependencies.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/llm-safety-consumer-test-reds

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske temporarily deployed to agent-standard July 26, 2026 00:27 — with GitHub Actions Inactive
@agents-workflows-bot

Copy link
Copy Markdown
Contributor

Workflow source needed

PR #2835 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

  • Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
  • Check one Workflow Source option in the PR body.
  • Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
  • Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

@stranske
stranske enabled auto-merge (squash) July 26, 2026 00:27
@agents-workflows-bot

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 8f0e0cd
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske merged commit d362a6c into main Jul 26, 2026
40 checks passed
@stranske
stranske deleted the fix/llm-safety-consumer-test-reds branch July 26, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant