chore: untrack the per-run langsmith worker-attempt artifact - #2856
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 26 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 989699f791
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| *.patch | ||
| coverage-local.* | ||
| pytest-junit*.xml | ||
| langsmith-fleet-worker-attempt.json |
There was a problem hiding this comment.
When reusable-codex-run.yml executes for a consumer, agent-run-base checks out that consumer at the workspace root, the artifact step writes this file there, and the later commit step runs git add -A. This ignore rule exists only in the Workflows root; templates/consumer-repo/.gitignore and the canonical patterns used by sync_status_file_ignores.py still omit it, so consumer runs will continue committing the per-run artifact. Add it to the consumer status-file block and fallback patterns for propagation, or explicitly unstage it in the reusable runner.
AGENTS.md reference: AGENTS.md:L39-L41
Useful? React with 👍 / 👎.
langsmith-fleet-worker-attempt.json is written per-run by reusable-codex-run.yml:1173 and uploaded as a build artifact; nothing reads it from the repo. While tracked, every run that rewrote it produced a diff that codex-autofix then committed onto whatever PR happened to be open — two such commits landed on PR #2852 while it was in review. Remove it and add it to the existing .gitignore block for per-run CI snapshots. It was also not on config/root-allowlist.txt, which health-40's "Root allowlist guard" enforces. While auditing that, four other tool-mandated root config files turned out to be unlisted as well, so add them: .coderabbit.yaml, .release-please-manifest.json, release-please-config.json, renovate.json. The guard has not been reporting any of this because it is skipped — the earlier "Snapshot branch protection state" step fails first (see PR body). Deliberately NOT changed: testgen_gate.py (a one-off #2620 acceptance gate, referenced by nothing) is left for an explicit keep-or-delete decision rather than silently blessed by an allowlist entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
989699f to
0c0a67f
Compare
Automated Status SummaryHead SHA: 4adafa8
Coverage Overview
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Restores mergeability. The only true conflict was langsmith-fleet-worker-attempt.json, a per-run artifact this branch modified and main untracked in #2856 ("chore: untrack the per-run langsmith worker-attempt artifact"); main's deletion is taken, dropping the out-of-scope artifact from this PR. Both agents-auto-pilot.yml copies merged cleanly: main's only change since the merge base was the actions/setup-python v6 -> v7 SHA bump, which is preserved alongside this branch's handoff-safeguard changes. Root and consumer-template copies remain byte-identical.
1 participant
Why
langsmith-fleet-worker-attempt.jsonis written per run byreusable-codex-run.yml:1173and uploaded as a build artifact (:1183). Nothing reads it from the repo. While tracked, every run that rewrote it produced a diff thatcodex-autofixthen committed onto whatever PR happened to be open — two such commits landed on #2852 while it was in review (cd8daf6,cf81a94), which is how I found it.It was also not on
config/root-allowlist.txt, which health-40's "Root allowlist guard" enforces (it exits 1 on any tracked depth-0 file not on the list — issue #2277).What changed
langsmith-fleet-worker-attempt.jsonand add it to the existing.gitignoreblock for per-run CI snapshots, so autofix can't re-commit it..coderabbit.yaml,.release-please-manifest.json,release-please-config.json,renovate.json. These must live at the repo root for CodeRabbit / release-please / Renovate to find them, so allowlisting (the guard's own documented remedy) is correct.Verified with the guard's exact logic (
git ls-files | awk -F/ 'NF==1' | grep -vxF -f config/root-allowlist.txt): before this PR 6 files were unlisted; after it, onlytestgen_gate.pyremains.Two things deliberately NOT changed
testgen_gate.py— a 135-line one-off acceptance gate for [Route Weight][testgen] Add round-1 repo-review schema validator edge tests #2620, referenced by nothing but itself. That is exactly the "stray fixer script" class the guard was built to catch, so I did not allowlist it (that would silently bless it) and did not delete it (it is not mine to discard). It needs an explicit keep-or-delete decision. Until then the guard would still flag it.health-40's real failure. The Root allowlist guard has never reported any of the above because it is skipped — step 11 "Snapshot branch protection state" fails first, so steps 13 (the guard) and 14 (Aggregate & Summarize) never run. health-40 has failed on that step for four consecutive weekly runs (2026-07-06, -13, -20, -27). That looks like a token/permissions issue rather than a code defect, so it is out of scope here, but it means this guard is currently blind and the debt above accumulated unseen.
🤖 Generated with Claude Code