Skip to content

fix: preserve CRLF for Windows command files - #2859

Merged
stranske merged 2 commits into
mainfrom
codex/preserve-cmd-crlf
Jul 31, 2026
Merged

fix: preserve CRLF for Windows command files#2859
stranske merged 2 commits into
mainfrom
codex/preserve-cmd-crlf

Conversation

@stranske

@stranske stranske commented Jul 31, 2026

Copy link
Copy Markdown
Owner

What changed

  • Declare *.cmd files as text with CRLF worktree line endings in the synced .gitattributes source.

Why

The consumer sync overwrote Counter_Risk’s repo-local launcher rule, converting its Windows launcher to LF and failing tests/test_windows_gui_launcher.py on Linux. A generic source rule keeps Windows command files usable and prevents future consumer syncs from reintroducing the failure.

Validation

  • pytest tests/workflows/test_sync_manifest_delivery.py -q (7 passed)
  • Counter_Risk focused launcher test passes after applying the synced rule (1 passed)

@cursor

cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@stranske
stranske marked this pull request as ready for review July 31, 2026 16:21
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 5 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 837e9af5-fad6-4040-869e-0bd643dc86a1

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd2488 and a7aced2.

📒 Files selected for processing (3)
  • .gitattributes
  • .github/workflows/maint-68-sync-consumer-repos.yml
  • tests/workflows/test_sync_manifest_delivery.py

Comment @coderabbitai help to get the list of available commands.

@stranske-keepalive

stranske-keepalive Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 3305a6e
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 75.91%
Baseline 85.00%
Delta -9.09%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske temporarily deployed to agent-standard July 31, 2026 16:22 — with GitHub Actions Inactive
@agents-workflows-bot

agents-workflows-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Workflow source detected

PR #2859 now has valid workflow source context (origin=local_request).

No linked GitHub issue is required for this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb3186cf0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitattributes
@stranske
stranske temporarily deployed to agent-high-privilege July 31, 2026 16:27 — with GitHub Actions Inactive
@stranske

stranske commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

Closer review verification on current head a7aced22: the P1 sparse-checkout finding is fixed and its review thread is resolved. Validation: pytest tests/workflows/test_sync_manifest_delivery.py -q = 7 passed; python scripts/validate_workflow_yaml.py .github/workflows/maint-68-sync-consumer-repos.yml passes; python scripts/validate_template_completeness.py passes; git diff --check origin/main...HEAD is clean. The bundled ./actionlint is not executable on this Mac (exec format error), while the current remote Parse and lint workflows check is green. The PR already carries valid <!-- workflow-source:local_request --> provenance. Fresh Gate still has async jobs in progress, so no merge is attempted this round.

@stranske

stranske commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

Correction log: the initial closer note referenced a nonexistent scripts/validate_yaml.py path and an undefined workflow:source-review-followup label; neither produced a change. The note above has been corrected to the commands and current remote check that actually passed. No provenance repair is needed because the PR body already contains <!-- workflow-source:local_request -->.

@stranske
stranske merged commit 1ad4624 into main Jul 31, 2026
51 checks passed
@stranske
stranske deleted the codex/preserve-cmd-crlf branch July 31, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants