feat(codex): promote Terra runner defaults - #2904
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Workflow source neededPR #2904 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
📝 WalkthroughWalkthroughCodex defaults, fallback models, and CLI versions were updated across workflows, registries, tests, and documentation. Verifier workflow expressions and output formatting were also reformatted without changing their described behavior. ChangesCodex routing update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Automated Status SummaryHead SHA: ed761ef
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f860b2c30f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR promotes the Codex runner’s default execution profile across workflows, registry, tests, and docs to use gpt-5.6-terra (with gpt-5.5 fallback) and bumps the pinned Codex CLI to 0.144.1, while also reflowing verifier workflow content to satisfy YAML long-line constraints.
Changes:
- Update Codex defaults (model, fallback model, CLI version) across reusable workflows and registry-backed profiles.
- Adjust workflow tests to assert the new defaults and tolerate YAML-folded env formatting.
- Refresh documentation to reflect the new Codex default model/fallback and verifier checkbox defaults.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/workflows/test_workflow_llm_installs.py |
Updates expected default Codex model/CLI and fallback model; removes gpt-5.4 expectations. |
tests/workflows/test_verifier_terminal_disposition.py |
Updates verifier expectations for Codex CLI/model defaults; normalizes folded env strings in assertions. |
templates/consumer-repo/.github/agents/registry.yml |
Promotes codex-default profile to gpt-5.6-terra with gpt-5.5 fallback. |
docs/WORKFLOW_GUIDE.md |
Documents verifier checkbox default model/fallback update. |
docs/keepalive/MULTI_AGENT_ROUTING.md |
Updates Codex routing table to new default/fallback models. |
docs/keepalive/GoalsAndPlumbing.md |
Updates Codex routing table to new default/fallback models. |
docs/ci/WORKFLOWS.md |
Documents new reusable-codex-run default/fallback and verifier checkbox default model/fallback. |
.github/workflows/reusable-codex-run.yml |
Updates default codex_cli_version, codex_model, and fallback models. |
.github/workflows/reusable-agents-verifier.yml |
Updates Codex CLI install/version defaults and reflows multiple long lines; introduces multiline Python extraction blocks. |
.github/scripts/__tests__/agent-registry.test.js |
Updates expected registry-backed Codex model contract defaults. |
.github/agents/registry.yml |
Promotes codex-default profile to gpt-5.6-terra with gpt-5.5 fallback. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/reusable-agents-verifier.yml:
- Line 482: Update the Codex CLI installation step around the npm install
command to make dependency resolution reproducible: use a committed lockfile
with a locked install, or verify the exact package artifact and checksum before
installation. Preserve the pinned `@openai/codex` version while ensuring
transitive dependencies cannot change between workflow runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d13b44df-c8b1-40ed-af61-1f21aca0c2c3
📒 Files selected for processing (11)
.github/agents/registry.yml.github/scripts/__tests__/agent-registry.test.js.github/workflows/reusable-agents-verifier.yml.github/workflows/reusable-codex-run.ymldocs/WORKFLOW_GUIDE.mddocs/ci/WORKFLOWS.mddocs/keepalive/GoalsAndPlumbing.mddocs/keepalive/MULTI_AGENT_ROUTING.mdtemplates/consumer-repo/.github/agents/registry.ymltests/workflows/test_verifier_terminal_disposition.pytests/workflows/test_workflow_llm_installs.py
|
Closer audit: the two verdict-parsing findings are valid on current |
Completes the bounded, unlinked review-residue follow-up for #2904. No source issue closure or verifier label applies.
Closer closeout — parent review threads resolved via merged #2907Follow-up #2907 merged at
All four parent threads resolved this round. |
Summary
gpt-5.6-terra0.144.1, retaininggpt-5.5fallbackValidation
uv run --extra dev pytest tests/workflows/test_verifier_terminal_disposition.py tests/workflows/test_workflow_llm_installs.py tests/workflows/test_model_profile_trial_workflows.py tests/docs/test_workflow_source_docs.py tests/workflows/test_sync_manifest_delivery.py— 52 passed, 2 policy skipsnode --test .github/scripts/__tests__/agent-registry.test.js— 28 passedpython3 scripts/validate_workflow_yaml.py .github/workflows/reusable-codex-run.yml .github/workflows/reusable-agents-verifier.ymlgit diff --checkThe branch was rebased onto current
mainimmediately before push.Summary by CodeRabbit
New Features
gpt-5.6-terraby default, withgpt-5.5as a fallback.0.144.1.Bug Fixes
Documentation
Tests