Skip to content

feat(codex): promote Terra runner defaults - #2904

Merged
stranske merged 1 commit into
mainfrom
agent/terra-runner-verifier
Aug 3, 2026
Merged

feat(codex): promote Terra runner defaults#2904
stranske merged 1 commit into
mainfrom
agent/terra-runner-verifier

Conversation

@stranske

@stranske stranske commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • promote the reusable Codex runner and registry-backed default profile to gpt-5.6-terra
  • migrate checkbox verification to Terra on Codex CLI 0.144.1, retaining gpt-5.5 fallback
  • fix all verifier workflow YAML long-line violations and preserve source/template parity

Validation

  • uv run --extra dev pytest tests/workflows/test_verifier_terminal_disposition.py tests/workflows/test_workflow_llm_installs.py tests/workflows/test_model_profile_trial_workflows.py tests/docs/test_workflow_source_docs.py tests/workflows/test_sync_manifest_delivery.py — 52 passed, 2 policy skips
  • node --test .github/scripts/__tests__/agent-registry.test.js — 28 passed
  • python3 scripts/validate_workflow_yaml.py .github/workflows/reusable-codex-run.yml .github/workflows/reusable-agents-verifier.yml
  • source/template registry parity and git diff --check

The branch was rebased onto current main immediately before push.

Summary by CodeRabbit

  • New Features

    • Updated automated workflow execution to use gpt-5.6-terra by default, with gpt-5.5 as a fallback.
    • Updated the Codex CLI version to 0.144.1.
  • Bug Fixes

    • Improved workflow logging, model fallback handling, verdict processing, and terminal status reporting.
  • Documentation

    • Updated workflow guides and routing documentation to reflect the new model and CLI defaults.
  • Tests

    • Updated compatibility and workflow verification tests for the new configuration.

Copilot AI review requested due to automatic review settings August 3, 2026 00:03
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@stranske-keepalive

Copy link
Copy Markdown
Contributor

Workflow source needed

PR #2904 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

  • Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
  • Check one Workflow Source option in the PR body.
  • Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
  • Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Codex defaults, fallback models, and CLI versions were updated across workflows, registries, tests, and documentation. Verifier workflow expressions and output formatting were also reformatted without changing their described behavior.

Changes

Codex routing update

Layer / File(s) Summary
Model defaults and compatibility validation
.github/agents/registry.yml, .github/scripts/__tests__/agent-registry.test.js, .github/workflows/reusable-codex-run.yml, .github/workflows/reusable-agents-verifier.yml, templates/consumer-repo/.github/agents/registry.yml, tests/workflows/*, docs/...
Codex now uses CLI 0.144.1, gpt-5.6-terra as the default model, and gpt-5.5 as fallback. Registries, compatibility mappings, tests, and documentation reflect these values.
Verifier logging and disposition formatting
.github/workflows/reusable-agents-verifier.yml, tests/workflows/test_verifier_terminal_disposition.py
Long messages, verdict parsing, hard-gate output, environment expressions, terminal disposition output, and related assertions were reformatted. The summarized behavior remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: agent:codex

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: promoting Terra as the default Codex runner model.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/terra-runner-verifier

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske temporarily deployed to agent-high-privilege August 3, 2026 00:03 — with GitHub Actions Inactive
Comment thread .github/workflows/reusable-agents-verifier.yml
@stranske-keepalive

stranske-keepalive Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: ed761ef
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 76.06%
Baseline 85.00%
Delta -8.94%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske temporarily deployed to agent-high-privilege August 3, 2026 00:05 — with GitHub Actions Inactive

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f860b2c30f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/reusable-agents-verifier.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the Codex runner’s default execution profile across workflows, registry, tests, and docs to use gpt-5.6-terra (with gpt-5.5 fallback) and bumps the pinned Codex CLI to 0.144.1, while also reflowing verifier workflow content to satisfy YAML long-line constraints.

Changes:

  • Update Codex defaults (model, fallback model, CLI version) across reusable workflows and registry-backed profiles.
  • Adjust workflow tests to assert the new defaults and tolerate YAML-folded env formatting.
  • Refresh documentation to reflect the new Codex default model/fallback and verifier checkbox defaults.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/workflows/test_workflow_llm_installs.py Updates expected default Codex model/CLI and fallback model; removes gpt-5.4 expectations.
tests/workflows/test_verifier_terminal_disposition.py Updates verifier expectations for Codex CLI/model defaults; normalizes folded env strings in assertions.
templates/consumer-repo/.github/agents/registry.yml Promotes codex-default profile to gpt-5.6-terra with gpt-5.5 fallback.
docs/WORKFLOW_GUIDE.md Documents verifier checkbox default model/fallback update.
docs/keepalive/MULTI_AGENT_ROUTING.md Updates Codex routing table to new default/fallback models.
docs/keepalive/GoalsAndPlumbing.md Updates Codex routing table to new default/fallback models.
docs/ci/WORKFLOWS.md Documents new reusable-codex-run default/fallback and verifier checkbox default model/fallback.
.github/workflows/reusable-codex-run.yml Updates default codex_cli_version, codex_model, and fallback models.
.github/workflows/reusable-agents-verifier.yml Updates Codex CLI install/version defaults and reflows multiple long lines; introduces multiline Python extraction blocks.
.github/scripts/__tests__/agent-registry.test.js Updates expected registry-backed Codex model contract defaults.
.github/agents/registry.yml Promotes codex-default profile to gpt-5.6-terra with gpt-5.5 fallback.

Comment thread .github/workflows/reusable-agents-verifier.yml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/reusable-agents-verifier.yml:
- Line 482: Update the Codex CLI installation step around the npm install
command to make dependency resolution reproducible: use a committed lockfile
with a locked install, or verify the exact package artifact and checksum before
installation. Preserve the pinned `@openai/codex` version while ensuring
transitive dependencies cannot change between workflow runs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d13b44df-c8b1-40ed-af61-1f21aca0c2c3

📥 Commits

Reviewing files that changed from the base of the PR and between 1e303fc and f860b2c.

📒 Files selected for processing (11)
  • .github/agents/registry.yml
  • .github/scripts/__tests__/agent-registry.test.js
  • .github/workflows/reusable-agents-verifier.yml
  • .github/workflows/reusable-codex-run.yml
  • docs/WORKFLOW_GUIDE.md
  • docs/ci/WORKFLOWS.md
  • docs/keepalive/GoalsAndPlumbing.md
  • docs/keepalive/MULTI_AGENT_ROUTING.md
  • templates/consumer-repo/.github/agents/registry.yml
  • tests/workflows/test_verifier_terminal_disposition.py
  • tests/workflows/test_workflow_llm_installs.py

Comment thread .github/workflows/reusable-agents-verifier.yml
@stranske
stranske merged commit cbd8673 into main Aug 3, 2026
99 of 111 checks passed
@stranske
stranske deleted the agent/terra-runner-verifier branch August 3, 2026 00:15
@stranske

stranske commented Aug 3, 2026

Copy link
Copy Markdown
Owner Author

Closer audit: the two verdict-parsing findings are valid on current main, and the reproducible-install finding is also valid. Follow-up #2907 repairs the parser and replaces the global floating-resolution install with a committed npm ci lockfile. The original review threads remain open until #2907 passes review and merges; #2904 has no linked source issue, so no verify:* label or issue closure is applicable.

stranske added a commit that referenced this pull request Aug 3, 2026
Completes the bounded, unlinked review-residue follow-up for #2904. No source issue closure or verifier label applies.
@stranske

stranske commented Aug 3, 2026

Copy link
Copy Markdown
Owner Author

Closer closeout — parent review threads resolved via merged #2907

Follow-up #2907 merged at 2026-08-03T11:22:58Z (21d6459f) and closed the four live review findings that remained on this PR after merge:

Finding Resolution in #2907
IndentationError in multiline python -c verdict parsing (Codex + Copilot P1) Restored unindented one-line python -c verdict parsing
Unlocked global npm install -g / zizmor ad-hoc package install Committed verifier-codex-cli/package-lock.json + npm ci; consumer install from .workflows-lib/.github/actions/verifier-codex-cli
Bare codex exec vs pinned local binary Install exports CODEX_CLI via $GITHUB_ENV; run step invokes "$CODEX_CLI" exec with unset/non-executable guard

All four parent threads resolved this round. #2907 has 0 unresolved threads. No source issue / closingIssuesReferences on either PR — verify:* and issue close remain unauthorized for this unlinked review-residue chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants