Skip to content

Fix ORM Create FullText index error if no text colums founded#1950

Merged
lauriejim merged 3 commits into
strapi:masterfrom
marcellovetro:Fix_fulltextindex
Sep 16, 2018
Merged

Fix ORM Create FullText index error if no text colums founded#1950
lauriejim merged 3 commits into
strapi:masterfrom
marcellovetro:Fix_fulltextindex

Conversation

@marcellovetro
Copy link
Copy Markdown
Contributor

... If aren't text colums definend in the schema do not lanch the SQL to create the fulltext index that generate the following SQL Error:

Error: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')' at line 1
...
sql: 'CREATE FULLTEXT INDEX SEARCH_MY_TABLE ON my_table ()'

My PR is a:
🐛 Bug fix

Main update on the:
Framework strapi-hook-bookshelf with Relational DBs such as MySql

New pull request from #1845

… definend in the schema do not lanch the SQL to create the fulltext index.
@marcellovetro
Copy link
Copy Markdown
Contributor Author

Linked to #1382 and #1907

@derrickmehaffy
Copy link
Copy Markdown
Member

@marcellovetro you can close the old one now 😉

Copy link
Copy Markdown
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thank you for this PR!

@lauriejim lauriejim self-assigned this Sep 14, 2018
@lauriejim lauriejim added pr: 🐛 Bug fix source: core:strapi Source is core/strapi package labels Sep 14, 2018
@lauriejim lauriejim merged commit 683732e into strapi:master Sep 16, 2018
@derrickmehaffy
Copy link
Copy Markdown
Member

Error still exists:

#1382 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source: core:strapi Source is core/strapi package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants