Fixes issues when doing an 'IN' query#2156
Merged
Merged
Conversation
When doing an 'IN' query it looks like this will incorrectly loop over the values and put them into multiple where clauses. This additional check on the symbol should leave the array untouched and pass it on into the orm for processing.
Contributor
|
Hello @greatwitenorth , thank you for this PR. Not sure to completely understand what you want. |
Contributor
Author
|
Consider the following custom method in a controller file: api/product/controllers/Product.js and the following added to routes: Currently a call to The following SQL is produced which is incorrect: With the proposed change, the system works as intended and returns products with ID 1,2,3. |
lauriejim
approved these changes
Oct 22, 2018
Contributor
lauriejim
left a comment
There was a problem hiding this comment.
Good ! Thank you for this fix !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing an 'IN' query it looks like this will incorrectly loop over the values and put them into multiple where clauses. This additional check on the symbol should leave the array untouched and pass it on into the orm for processing.
My PR is a:
🐛 Bug fix
Main update on the:
Framework