Skip to content

[V4] fix: error in CM when deleting components from DZ#23002

Merged
Bassel17 merged 1 commit intov4from
fix/v4-delete-components
Feb 26, 2025
Merged

[V4] fix: error in CM when deleting components from DZ#23002
Bassel17 merged 1 commit intov4from
fix/v4-delete-components

Conversation

@Bassel17
Copy link
Copy Markdown
Member

What does it do?

  • removes unnecessary target check in isMorphRelationWithPivot method in the remove-orphan-morph-types repair method

Why is it needed?

  • when removing components that exist in a dynamic zone, the join table between the entity and component resulting in a an error whenever trying to save and edit to the contentType in the Content Manager

How to test it?

  • Create component,
  • create a DZ and add the component
  • fill the component in the with some test data in the content-manager and save it
  • delete component from contentType builder
  • come back to the contentType that used to have this component attempt to edit anything and save

this process should work with no error

Related issue(s)/PR(s)

fixes #19535

@Bassel17 Bassel17 added source: core:database Source is core/database package pr: fix This PR is fixing a bug labels Feb 26, 2025
@Bassel17 Bassel17 self-assigned this Feb 26, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 2:22pm

@Bassel17 Bassel17 added this to the 4.25.21 milestone Feb 26, 2025
@Bassel17 Bassel17 changed the title fix: error in CM when deleting components from DZ fix: error in CM when deleting components from DZ [V4] Feb 26, 2025
@Bassel17 Bassel17 changed the title fix: error in CM when deleting components from DZ [V4] [V4] fix: error in CM when deleting components from DZ Feb 26, 2025
Copy link
Copy Markdown
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bassel17 Bassel17 merged commit 99934b4 into v4 Feb 26, 2025
157 checks passed
@Bassel17 Bassel17 deleted the fix/v4-delete-components branch February 26, 2025 16:04
@Bassel17 Bassel17 linked an issue Feb 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug source: core:database Source is core/database package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug V4: tries to find Metadata after remove a component

2 participants