Skip to content

ci: match v4 tooling packages to v5#23021

Merged
innerdvations merged 2 commits intov4from
chore/upgrade-tooling-v4
Feb 28, 2025
Merged

ci: match v4 tooling packages to v5#23021
innerdvations merged 2 commits intov4from
chore/upgrade-tooling-v4

Conversation

@innerdvations
Copy link
Copy Markdown
Contributor

@innerdvations innerdvations commented Feb 27, 2025

What does it do?

  • use the same versions of lerna and @actions/github as the develop branch
  • ignore .nx in prettier

Why is it needed?

to eliminate several packages with vulnerabilities from the yarn.lock; none of them actually affect anything, but it triggers dependabot alerts and vulnerability warnings

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@innerdvations innerdvations added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Feb 27, 2025
@innerdvations innerdvations added this to the 4.25.21 milestone Feb 27, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) Feb 27, 2025 5:10pm

@github-actions
Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 1.33 MB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.28 kB
examples/getstarted/build/index.html 606 B
examples/getstarted/build/main.********.js 1.32 MB
examples/getstarted/build/runtime~main.********.js 4.27 kB

compressed-size-action

Copy link
Copy Markdown
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any breaking change impacting us in this?

@innerdvations
Copy link
Copy Markdown
Contributor Author

innerdvations commented Feb 27, 2025

Is there any breaking change impacting us in this?

There shouldn't be, as long as the monorepo builds. But there does seem to be some sort of conflict with nx in github. I'll take a look later.

Update: It was just some cache files that needed to be ignored

@innerdvations innerdvations merged commit 9716828 into v4 Feb 28, 2025
37 of 39 checks passed
@innerdvations innerdvations deleted the chore/upgrade-tooling-v4 branch February 28, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants