Skip to content

Add note about docker to deployment documentation#2629

Merged
lauriejim merged 3 commits into
strapi:masterfrom
MartinMuzatko:patch-1
Jan 23, 2019
Merged

Add note about docker to deployment documentation#2629
lauriejim merged 3 commits into
strapi:masterfrom
MartinMuzatko:patch-1

Conversation

@MartinMuzatko
Copy link
Copy Markdown
Contributor

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix #issueNumber
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the follow databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

Description:

Currently there is no note of docker in the documentation. Maybe this is because the docker image is a bit older. I think this is missing from the docs.

@MartinMuzatko MartinMuzatko changed the title Add note about docker to deployment Add note about docker to deployment documentation Jan 15, 2019
@derrickmehaffy
Copy link
Copy Markdown
Member

Bad @lucaperret 😛

FROM node:11.1.0-alpine

@MartinMuzatko
Copy link
Copy Markdown
Contributor Author

  1. Alpine is not ARM friendly
  2. Node 11 is unstable

After this, I'm helping with the docker repo ;)

@derrickmehaffy
Copy link
Copy Markdown
Member

@MartinMuzatko Awesome, is this official? If not cough @lauriejim get him in there to help. 😆

@MartinMuzatko
Copy link
Copy Markdown
Contributor Author

NodeJS marks every odd numbered release number as unstable: https://github.com/nodejs/Release#release-plan

That means 6,8,10,12 are considered as stable and 7,9,11 unstable.

That does not actually mean that they are not working or broken, they just use odd numbers as experimental releases.

@lauriejim lauriejim added this to the 3.0.0-alpha.21 milestone Jan 23, 2019
@lauriejim lauriejim self-assigned this Jan 23, 2019
@lauriejim lauriejim self-requested a review January 23, 2019 10:11
Copy link
Copy Markdown
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's add some info about that.

@lauriejim lauriejim merged commit 30c180e into strapi:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source: docs Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants