Conversation
ethanrublee
reviewed
Aug 4, 2021
sophus/common.hpp
Outdated
| #define FMT_STRING_ALIAS 1 | ||
| #endif | ||
|
|
||
| #define FMT_HEADER_ONLY |
Collaborator
There was a problem hiding this comment.
Possibly this should be defined at the cmake level. I worry this might mess with other users of the library.
Collaborator
There was a problem hiding this comment.
Owner
Author
There was a problem hiding this comment.
yes, using the fmt::fmt-header-only target instead
CMakeLists.txt
Outdated
|
|
||
| # Create 'test' make target using ctest | ||
| option(BUILD_TESTS "Build tests." ON) | ||
| option(BUILD_TESTS "Build tests." OFF) |
Collaborator
There was a problem hiding this comment.
Changing the defaults here seems like it could be breaking for others. Suggest this is just done at the configuration level.
Owner
Author
There was a problem hiding this comment.
okay, renaming to BUILD_SOPHUS_TESTS, but leaving the default as is
Hs293Go
pushed a commit
to Hs293Go/Sophus
that referenced
this pull request
Jan 21, 2022
…at#312) * C-spline implementation on Lie Group; some cmake/build tweaks * adressing review comments
Hs293Go
pushed a commit
to Hs293Go/Sophus
that referenced
this pull request
Jan 21, 2022
…at#312) * C-spline implementation on Lie Group; some cmake/build tweaks * adressing review comments
Hs293Go
pushed a commit
to Hs293Go/Sophus
that referenced
this pull request
Jan 21, 2022
…at#312) * C-spline implementation on Lie Group; some cmake/build tweaks * adressing review comments
Hs293Go
pushed a commit
to Hs293Go/Sophus
that referenced
this pull request
Jan 21, 2022
…at#312) * C-spline implementation on Lie Group; some cmake/build tweaks * adressing review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.