refactor(channels-sv2): Update share validation result with share metadata#1965
Closed
average-gary wants to merge 2 commits into
Closed
refactor(channels-sv2): Update share validation result with share metadata#1965average-gary wants to merge 2 commits into
average-gary wants to merge 2 commits into
Conversation
…adata - Modify `ShareValidationResult` enum to include `share_work` and `share_hash` for both `Valid` and `BlockFound` variants - Update share validation logic in `extended.rs`, `standard.rs` to pass share metadata
plebhash
reviewed
Oct 24, 2025
Comment on lines
+54
to
+57
| acknowledgement: bool, | ||
| last_sequence_number: u32, | ||
| new_submits_accepted_count: u32, | ||
| new_shares_sum: u64, |
Member
There was a problem hiding this comment.
all of this can be achieved in the application layer by calling get_share_accounting
plebhash
reviewed
Oct 24, 2025
| /// - `new_submits_accepted_count`: The number of new shares accepted in this batch | ||
| /// - `new_shares_sum`: The total work contributed by shares in this batch | ||
| Valid { | ||
| share_work: f64, |
Member
There was a problem hiding this comment.
this can be retrieved in the application layer by calling get_target
plebhash
reviewed
Oct 24, 2025
| format!("{:x}", network_target) | ||
| ); | ||
|
|
||
| let share_work = self.target.difficulty_float(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShareValidationResultenum to includeshare_workandshare_hashfor bothValidandBlockFoundvariantsextended.rs,standard.rsto pass share metadataMinimal returned data from
validate_share()to enable application side handling. i.e. Persistence.