Fix version mask unvalid len#2109
Merged
plebhash merged 2 commits intostratum-mining:mainfrom Mar 5, 2026
Merged
Conversation
exd02
force-pushed
the
fix/version-mask-unvalid-len
branch
from
bc0bf1f to
1fbc1d8
Compare
GitGab19
reviewed
Mar 4, 2026
GitGab19
approved these changes
Mar 4, 2026
exd02
force-pushed
the
fix/version-mask-unvalid-len
branch
3 times, most recently
from
08d0596 to
1fbc1d8
Compare
This test causes panic before the previous commit fix. This crash was caused by an underflow integer bug, where the length the version mask was greater than 8 bytes in the utils.rs:try_from function.
exd02
force-pushed
the
fix/version-mask-unvalid-len
branch
from
1fbc1d8 to
5a7b415
Compare
plebhash
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2108
This PR introduces a new error variant,
Error::InvalidHexLen, to handle cases wheremining.set_version_maskexceeds 8 bytes, which previously resulted in an underflow.The validation is added in
HexU32Be::try_from, returningInvalidHexLenwhen the input length is greater than the expected 8 hex characters.A test is included to ensure that a
mining.set_version_maskmessage with a length greater than 8 bytes fails withParsingMethodError::InvalidHexLen.