Make sv1 server trait methods return results#2134
Merged
Shourya742 merged 2 commits intostratum-mining:mainfrom Apr 21, 2026
Merged
Conversation
plebhash
approved these changes
Apr 17, 2026
GitGab19
reviewed
Apr 21, 2026
Member
GitGab19
left a comment
GitGab19
left a comment
There was a problem hiding this comment.
Don't we need a MAJOR bump of sv1_api here?
Member
Author
GitGab19
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: stratum-mining/sv2-apps#436
Luckily sv1 trait error type already return UnknownID when the downstream is not present, so we can use that to return the error for scenario mentioned in the issue above.
companion stratum-mining/sv2-apps#437