fix: prevent zoom on mobile when handleTouch is set to false#293
Merged
Conversation
Contributor
Author
|
Hey @billythekid, care to take a look at this and see what you think? I'm hoping this will solve the touch bug we discussed a few weeks ago. |
|
Heya @sherwinski, This appear to work well, on chrome devtools 'touch mode', firefox devtools 'touch mode' as well as chrome on iphone so I'm saying this is a good catch and a nice way to do it actually, just unbind the event. Thanks for checking it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that
touchstartevents on mobile will also trigger amouseenterevent by default, which will still create aZoomPaneelement even ifhandleTouchis set to false at instantiation. This PR will prevent that default behavior in scenarios wherehandleTouchis set to false.Fixes #273
fix(<area>): fixed bug #issue-numberSteps to Test
Behavior on base branch: https://codepen.io/billythekid/pen/WqZwmW
Behavior on this PR: https://codepen.io/sherwinski/pen/GbbGYP
In the base branch, a click will result in a "touchstart" and then a "mouseenter" event, whereas in the PR version only "touchstart" will execute.