test(config): guard example field coverage - #36
Draft
adity982 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
What changed
Configand collect every full dotted TOML path.config.toml.example.Scope correction
Current
mainalready contains the commented[pgvector]block and its fields from9c533b4c, so this PR deliberately does not duplicate Part 1. The remaining drift guard was confirmed with the maintainer in the issue thread.Why
config.toml.exampleis the copyable configuration reference. This test makes a newly added config field fail loudly until the example documents it, while preserving the project's intentionally commented optional settings.Validation
The branch was rebased onto current
upstream/main. The only conflict was the import block ininternal/config/config_test.go; the resolution preserves both upstream's new unknown-key tests and this PR's example-drift test, and the focused checks above were rerun after resolution.